fix(api-search): make operationId the leading default column - #238
Open
jpage-godaddy wants to merge 2 commits into
Open
fix(api-search): make operationId the leading default column#238jpage-godaddy wants to merge 2 commits into
jpage-godaddy wants to merge 2 commits into
Conversation
Rows for the same domain/method/path (e.g. many GraphQL sub-operations sharing one wrapper endpoint) rendered identically since operationId wasn't part of the default column set. Lead with it so it's the last column dropped when a row doesn't fit the terminal width.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates gddy api search output defaults so results are distinguishable when multiple endpoints share the same domain/method/path (e.g., GraphQL sub-operations), and refines the command’s help text.
Changes:
- Adds
operationIdas the leading default output column forapi search. - Tightens the
api search--helplong description.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The shortened long description dropped mention of summaries, but search_endpoints still matches against summary text — the help was out of sync with actual behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gddy api searchrows for shared domain/method/path (notably GraphQL sub-operations under one wrapper endpoint) rendered as visually identical rows sinceoperationId— the one field that's actually unique per row — wasn't part of the default column set.operationIdas the first default column so it's the highest-priority column and the last one dropped when a row doesn't fit the terminal width, and tighten the command's--helplong description.Test plan
cargo checkcargo clippy -- -D warningscargo testcargo fmt --check./rust/scripts/check-module-size.shgddy api search catalogand confirmedoperationIdnow distinguishes previously-identical-looking rows