Backdrop: Stroke/StrokeWidth for a bordered rounded ground - #219
Merged
Conversation
Backdrop.Radius gave a rounded fill but no border, so a bordered pill/chip still needed a hand-drawn StrokeRoundRect over the fill. Stroke (non-zero alpha) now outlines the optionally-rounded fill, StrokeWidth thick (< 1 treated as 1); the zero value draws no border, byte-identical. With Radius + Fill + Stroke a Backdrop is a complete pill/chip ground — a host composites a Label/icon over it instead of hand-drawing fill+border. 100% statement coverage; gofmt + vet clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backdrop.Radiusgave a rounded fill but no border, so a bordered pill/chip still needed a hand-drawnStrokeRoundRectover theBackdrop.Change
Stroke RGBA(non-zero alpha) outlines the optionally-rounded fill,StrokeWidththick (< 1treated as1). The zero value draws no border, byte-identical. WithFill+Radius+Stroke, aBackdropis a complete pill/chip ground — a host composites aLabel/icon over it instead of hand-drawing fill+border.Why
Lets the reader's remaining bordered pill (the preview A−/A+ zoom pills) become a
Backdrop+Labelinstead ofpt.FillRoundRect+pt.StrokeRoundRect.Tests / gates
TestBackdropStroke: no Stroke → no border colour; Stroke set (width defaulted from< 1) → border painted, centre stays the fill.gofmt+go vetclean.🤖 Generated with Claude Code