TreeView: HideRoot renders the root's children as a forest - #214
Merged
Conversation
A TreeView always rendered its single Root as the top row, so every other entry sat one indent level deeper — a host that wants its top-level items flush (e.g. a sidebar whose "All Sources" row should not indent the folders and subscriptions below it) had no way to omit the root. HideRoot makes flatten skip the root row and walk its children at depth 0 (ignoring the root's own Expanded flag, since it is no longer a visible, collapsible row). Selection, keyboard and hit-testing already operate on the flattened rows, so they need no change. The zero value keeps the original root-visible behaviour. 100% statement coverage; gofmt + vet clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TreeViewalways rendered its singleRootas the top row, forcing every other entry one indent level deeper. A host that wants its top-level items flush — e.g. a sidebar whose "All Sources" row should not indent the folders/subscriptions below it — had no way to omit the root row.Change
HideRoot bool: when true,flattenskips the root's own row and walks its children at depth 0 (the root'sExpandedflag is ignored, since it is no longer a visible/collapsible row). Selection, keyboard and hit-testing already operate on the flattenedrows, so they need no change. The zero value keeps the original root-visible behaviour, byte-identical to before.Tests / gates
Expanded, and theHideRoot=falsefallback.gofmt+go vetclean.🤖 Generated with Claude Code