test: self-manage .git in gitignore fixture tests#2908
Open
vmaerten wants to merge 1 commit into
Open
Conversation
The use_gitignore filtering resolves a repo root by walking up to a .git entry. An in-tree checkout inherits go-task's own .git, but a GitHub source tarball (common for distro packaging) has none, which silently disabled filtering and broke the golden fixtures. Have the gitignore integration tests create and clean up their own .git marker in the fixture dir so they validate real behavior regardless of the build source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #2907
The
use_gitignorefiltering added in 616433d resolves a repository root by walking up the directory tree to a.gitentry (internal/fingerprint/gitignore.go). When the tests run inside an in-tree checkout, the fixtures undertestdata/gitignore*inherit go-task's own.git, so filtering activates and the golden fixtures match.Test plan
.git:go test . -run TestGitignorefails on the ignored file modified steps.go test . -run TestGitignorestill passes, no golden files changed,git statusclean after the run (fixture.gitis cleaned up).go test ./...passes with no regressions.