Skip to content

Potential fixes for 4 code quality findings #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredbi merged 4 commits into from
Jul 16, 2026
Merged

Potential fixes for 4 code quality findings #217

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f819c4
Apply suggested fix to mixin.go from Copilot Autofix
fredbi Jul 16, 2026
17f2ca2
Apply suggested fix to mixin.go from Copilot Autofix
fredbi Jul 16, 2026
be7fcb7
Apply suggested fix to mixin.go from Copilot Autofix
fredbi Jul 16, 2026
a23cc03
Apply suggested fix to mixin.go from Copilot Autofix
fredbi Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mixin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func pathItemOps(p spec.PathItem) []*spec.Operation {
rv = appendOp(rv, p.Post)
rv = appendOp(rv, p.Delete)
rv = appendOp(rv, p.Head)
rv = appendOp(rv, p.Options)
rv = appendOp(rv, p.Patch)

return rv
Expand Down Expand Up @@ -213,9 +214,9 @@ func mergePaths(primary *spec.Swagger, m *spec.Swagger, opIDs map[string]bool, m
// Swagger requires that operationIds be
// unique within a spec. If we find a
// collision we append "Mixin0" to the
// operatoinId we are adding, where 0 is mixin
// operationId we are adding, where 0 is mixin
// index. We assume that operationIds with
// all the proivded specs are already unique.
// all the provided specs are already unique.
piops := pathItemOps(v)
for _, piop := range piops {
if opIDs[piop.ID] {
Expand Down Expand Up @@ -358,7 +359,7 @@ func mergeSwaggerProps(primary *spec.Swagger, m *spec.Swagger) []string {

if primary.ExternalDocs == nil {
primary.ExternalDocs = m.ExternalDocs
} else if m != nil {
} else if m.ExternalDocs != nil {
skippedDocs = mergeExternalDocs(primary.ExternalDocs, m.ExternalDocs)
skipped = append(skipped, skippedDocs...)
}
Expand Down
Loading