fix: use output filename in TypeScript usage imports#2948
Merged
Conversation
Signed-off-by: Aysajan Eziz <aeziz@northset.ai>
The previous commit only applied the output-filename-derived module name
to the TypeScript usage import comment; JavaScript (and Flow, which
inherits it) still emitted require("./file"). Hoist the module-name
derivation into a shared usageModuleName helper on JavaScriptRenderer,
use it in both the JavaScript require comment and the TypeScript import
comment, and extend the unit test to cover JavaScript, Flow, and the
stdout fallback.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the requested output filename in generated TypeScript usage imports instead of the hard-coded ./file module, with a focused regression.
Change
packages/quicktype-core/src/language/JavaScript/JavaScriptRenderer.tspackages/quicktype-core/src/language/TypeScriptFlow/FlowRenderer.tspackages/quicktype-core/src/language/TypeScriptFlow/TypeScriptFlowBaseRenderer.tspackages/quicktype-core/src/language/TypeScriptFlow/TypeScriptRenderer.tstest/unit/typescript-output-filename.test.tsChecks
npm run test:unit -- test/unit/typescript-output-filename.test.ts— passed in a network-isolated container.npm run lint— passed in a network-isolated container.npm run build— passed in a network-isolated container.Fixes #971
AI assistance was used; I reviewed and own this change.
Verification
Northset proof-of-pass receipt M-105
Contributor self-run; not maintainer verification.