Namespace admin APIs under x-speakeasy-group: admin#124
Closed
travis-hoover-glean wants to merge 2 commits into
Closed
Namespace admin APIs under x-speakeasy-group: admin#124travis-hoover-glean wants to merge 2 commits into
travis-hoover-glean wants to merge 2 commits into
Conversation
Move governance and datasource admin endpoints out of the client.* namespace and into a dedicated admin.* namespace so they are accessed as glean.admin.governance.*, glean.admin.datasources.*, etc. - governance data policies/reports/findings + document visibility overrides now live under admin.governance.* - datasource config/credential endpoints now grouped under admin.datasources
# Conflicts: # overlays/admin-modifications-overlay.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the admin/governance and datasource admin endpoints out of the
client.*namespace and into a dedicatedadmin.*namespace inoverlays/admin-modifications-overlay.yaml, so they're accessed asglean.admin.governance...,glean.admin.datasources..., etc.Groupings
admin.governance.data.policies— retrieve, update, list, create, downloadadmin.governance.data.reports— create, download, statusadmin.governance.data.findings.exports— create, list, download, delete (newly grouped)admin.governance.documents.visibilityoverrides— list, createadmin.datasources— getConfiguration, updateConfiguration, getCredentialStatus, rotateCredentials (newly grouped)Notes
client.governance.*; this just swaps theclient.prefix foradmin..admin_rest.yamlbut were not previously grouped by the overlay — they're now included so all admin APIs share theadmin.*namespace.admin.datasources. Open to nesting (e.g.admin.datasources.credentials.rotate) if preferred.