refactor(auth): remove legacy plaintext token migration#3031
Open
afonsojramos wants to merge 1 commit into
Open
refactor(auth): remove legacy plaintext token migration#3031afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
Drop the startup path that re-encrypted plaintext tokens for pre-safeStorage upgrades. Tokens are now expected to already be encrypted at rest; only keychain rotation ciphertext is persisted. Users still on plaintext tokens must re-login after this major release.
|
Member
|
Great, thanks for picking this up mate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persistRotatedAuthTokens.migrateLegacyAuthStatetosanitiseAuthStateso permanent auth sanitisation is not framed as a one-shot migration.Breaking change: users who still have unencrypted tokens from pre-safeStorage releases will need to re-login. Anyone who already upgraded through an encrypting release is unaffected.
Test plan
pnpm exec vitest run src/renderer/context/App.test.tsx(19 tests pass)reEncryptedTokenis returned