feat: enforce terminal-before-gh and credentials-before-run ordering constraints#238
Merged
Merged
Conversation
- Add environmentReady and agentCredentialsConfigured flags to default simulator state - 02-setup now sets flags.environmentReady = true - 06-install-gh-aw now requires flags.environmentReady (no gh install before terminal/codespace) - 06-install-gh-aw now sets flags.agentCredentialsConfigured when auth is present - 08-run-workflow now requires flags.agentCredentialsConfigured before running - Add Section 5 to guidelines.md documenting both ordering constraints Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…delines auth detail Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
feat: enforce ordering constraints — no gh before terminal, credentials before run
feat: enforce terminal-before-gh and credentials-before-run ordering constraints
Jul 11, 2026
Copilot created this pull request from a session on behalf of
pelikhan
July 11, 2026 23:34
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ordering bugs in the workshop simulator:
gh/gh-awcould be installed before any terminal was open, and workflows could run without agent credentials ever being configured.Simulator state (
simulator.js)environmentReady: falseandagentCredentialsConfigured: falseto default flagsJourney transitions (
workshop-student-journey.js)02-setup— setsflags.environmentReady = trueafter OS/terminal validation passes06-install-gh-aw— gates onflags.environmentReady(newenvironment-not-readyfailure category); setsflags.agentCredentialsConfigured = truewhenauth.isLoggedIn08-run-workflow— newensurecheck onflags.agentCredentialsConfigured(newagent-credentials-missingfailure category)Authoring guidelines (
guidelines.md)ghinstall before environment setup, and credential configuration must precede the run step.