Make prompt completion screens data-driven - #170
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Make prompt completion screens data driven
Make prompt completion screens data-driven
Aug 27, 2026
Copilot created this pull request from a session on behalf of
pelikhan
August 27, 2026 17:39
View session
pelikhan
marked this pull request as ready for review
August 27, 2026 20:14
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed (matt-pocock perspective — TS/JS focus). The refactor cleanly moves finish-screen/copy-modal strings into wizard.json with sensible fallback defaults preserved in ui.js (dataset.failureLabel || 'Copy failed — try again', etc.), and setText/dataset guards use typeof value === 'string' checks consistently to avoid clobbering DOM text with non-string config. Test coverage was extended appropriately in wizard-config.test.js and a11y.test.js. Ran the full suite locally — 197/197 tests pass. No blocking issues found; no line comments needed.
Generated by Specialist PR Review for #170 · auto · 23.2 AIC · ⌖ 2.32 AIC · ⊞ 7.9K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The finish screen and copy-success dialog used hardcoded wording, preventing wizard owners from customizing the final instructions through
wizard.json.Changes
Configuration
wizard.json.Runtime rendering
Coverage