Repository navigation
feat: release a signed, notarized Desktop Tools DMG - #28
Merged
Merged
Conversation
Refs #27 Why: scripts/release.ts | the app and its DMG are both notarized, stapled, and assessed by spctl before upload; notarytool info, not wait, decides the outcome Why: scripts/credentials.ts | signing material lives only in a disposable keychain under RUNNER_TEMP, removed by the always-run clean step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release side of #27. Builds with
assembleandsignfrom #29'sdist/app.js..github/workflows/release.yml:workflow_dispatch(optionalpublish), environmentrelease, macos-15 with Xcode 26.2,npm run check, then credentials → release → artifact upload →gh release create v<version>when publishing. Clean always runs.scripts/credentials.ts: port of Ace's; imports the Developer ID cert into a disposable keychain underRUNNER_TEMPand writes the notary key path toDT_NOTARY_KEY.scripts/release.ts: port of Ace's; assemble, sign, notarize (submit/wait 20m/info), staple with retry,spctl, then a DMG with an Applications link that is signed, notarized, stapled, validated, and assessed. Output:build/release/desktop-tools-<version>-macos-arm64.dmg.Needs in the
releaseenvironment:DT_CERTIFICATE_P12(base64),DT_CERTIFICATE_PASSWORD,DT_NOTARY_PRIVATE_KEY(.p8 contents)DT_CODESIGN_IDENTITY,DT_NOTARY_KEY_ID,DT_NOTARY_ISSUERVerified: both scripts type-check strict against the real
dist/app.js, andnpm run checkpasses; the credentials guard refuses outside Actions. Not yet run end to end (needs the app lane and the credentials).Built in Ace
Written with Claude Code outside Ace, coordinating with the study lead's Ace session; no Ace surface was needed for this lane.