Repository navigation
fix: refuse file URLs whose query or fragment would be dropped - #20
Merged
Merged
Conversation
Found in the Ace desktop tools study (githubnext/ace#427, D7): desktop_open of file:///…/compose.html?tick opened compose.html in Chrome without ?tick, and nothing said so. Why: native/sources/client/launch.swift | Open must not report success for a URL it can't deliver intact; file URLs reach apps as document paths.
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Ace desktop tools study (githubnext/ace#427, D7),
desktop_openwithfile:///…/compose.html?tickand Chrome as the application openedcompose.htmlwith no query. LaunchServices passes file URLs to apps as documents, so the query was dropped, and the open still reported success. The agent then misread what it saw.Open now refuses a file URL that has a query or a fragment, and says to serve the file over http or open it without one.