Closed
Fix landing page diagram rendering on iOS Safari dark mode#55
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
August 27, 2026 21:21
View session
pelikhan
marked this pull request as ready for review
August 27, 2026 22:21
Contributor
|
@copilot generate screenshots |
Contributor
Author
Built the docs site and captured the hero diagram on an iPhone-sized viewport (393×852, iOS Safari UA) with
Both variants now match the surrounding page theme instead of the diagram staying stuck in the light palette under dark mode. |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
mnkiefer
marked this pull request as draft
August 28, 2026 08:00
mnkiefer
marked this pull request as ready for review
August 28, 2026 08:00
Contributor
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Author
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
|
Closing in favor of new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hero diagram on the landing page baked its dark-mode colors into
@media (prefers-color-scheme: dark)rules embedded inside SVGs referenced via<img>and data URIs. Safari (iOS and macOS) does not evaluate that media query in this context, so the diagram rendered with the light palette on dark-mode iOS Safari, clashing with the surrounding dark page.Static fallback diagrams
control-plane-dispatch-fallback.svgandcontrol-plane-dispatch-mobile.svginto separate light and new*-dark.svgvariants with the palette baked in (no embedded media query).<picture>/<source media="(prefers-color-scheme: dark)">inHierarchyHero.astro, matching the pattern already used indocs/architecture.md.Lottie animation icons
control-plane-dispatch.animation.mjshad the same embedded-media-query pattern, referenced via data URIs.prefersDarkflag and resolve colors in JS instead of relying on the SVG's own media query.HierarchyHero.astronow detectsprefers-color-scheme: darkviamatchMedia, passes it to the animation builders, and re-initializes the animation when the OS scheme changes.