feat(templates): use {{ agent_display_name }} in all four base templates#758
Draft
Copilot wants to merge 1 commit into
Draft
feat(templates): use {{ agent_display_name }} in all four base templates#758Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/358c8297-559b-4d33-ac9e-8af4b391a685 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
May 26, 2026 10:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ agent_display_name }}was only referenced from1es-base.ymlandstage-base.yml. The standalone (base.yml) and job-target (job-base.yml) templates hard-codeddisplayName: "Agent"for the top-most user-facing label, so every pipeline rendered identically in the ADO UI regardless of the agent'sname:.displayName: "Agent"on the Agent job insrc/data/base.ymlandsrc/data/job-base.ymlwith{{ agent_display_name }}, matching the existing stage-level usage in the 1ES and stage templates.docs/template-markers.mdandsite/src/content/docs/reference/template-markers.mdxto document the marker as used by all four base templates instead of a 1ES/stage-only subset.tests/safe-outputs/*.lock.ymlfixtures; the diffs also pick up incidental drift (compiler0.30.1 → 0.30.2, Copilot CLIv1.0.47 → v1.0.48) from recompiling against the current binary.Example diff for the standalone template:
…which now renders e.g.
displayName: "Daily safe-output smoke: noop"instead ofdisplayName: "Agent".Test plan
cargo test --release --test compiler_tests tricky— the YAML-escaping regression tests for tricky agent names (embedded"and:) still pass, confirmingyaml_double_quotedhandles the new substitution sites.cargo test --release— 103 passing; the 11 pre-existing--debug-pipelinefailures reproduce on a cleanmainand are unrelated.git diff tests/safe-outputs/noop.lock.ymlto confirm the only structural change is the Agent-jobdisplayNameflipping to the front-matter name.