Skip to content

fix(desktop): resolve Save sheet controls to their parent window #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 2 commits into from
Oct 15, 2026
Merged

fix(desktop): resolve Save sheet controls to their parent window #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afa390e
fix(desktop): resolve Save sheet controls to their parent window
iamnbutler Oct 15, 2026
071f599
lane: sync sheet-window memory
iamnbutler Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../memory/package.json/01M4X5AF9TCS4B752Z16B7W75M-oxlint-applies-the-shared-gi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: '@file'
created: 2026-10-14T12:13:47Z
norm: '1'
sig: 021fb596db81e6d0
body_hash: 82cf2861a64e01c2
raw_hash: 5d6dac437fb3286a
vouched: 2026-10-14T12:31:20Z
body_hash: 14b1f1e585aec5e3
raw_hash: d2d245c9bcd1a59d
vouched: 2026-10-15T05:59:13Z
lines: 1-92
---

Expand Down
12 changes: 12 additions & 0 deletions .../memory/package.json/01M4Z29775079GGN4MM0135FX3-desktop-tools-must-stay-at-o.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
id: 01M4Z29775079GGN4MM0135FX3
anchor: '@file'
created: 2026-10-15T05:59:09Z
norm: '1'
sig: 021fb596db81e6d0
body_hash: 14b1f1e585aec5e3
raw_hash: d2d245c9bcd1a59d
lines: 1-94
---

desktop-tools must stay at or after ccb4750 so sheet controls resolve to the AXWindow the sheet is attached to; older pins refuse every mutation on Save/Open sheets (#378)
6 changes: 3 additions & 3 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"@tailwindcss/vite": "4.3.0"
},
"desktop": {
"@githubnext/desktop-tools": "github:githubnext/desktop-tools#8efe67fbd38ed293c8e76778f01814b3bd67c5db",
"@githubnext/desktop-tools": "github:githubnext/desktop-tools#ccb4750ded4ea4c0d365d0604b5c24eecd843bc6",
"electrobun": "1.18.1",
"@types/three": "0.165.0"
}
Expand Down