Conversation
|
🚀 New build available for commit |
Collaborator
|
Wow. I see that the wrong variable was compared. |
gr5
approved these changes
Aug 20, 2026
gr5
left a comment
gr5
left a comment
Collaborator
There was a problem hiding this comment.
code looks good. Tested and it works. Works with npz files as well 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#358 is not fully implemented as proposed in discussion.
But this is a very minimal fix because the "yes" button has not any effect at all.
I need it for other PR and I don't want to do the full correction because it would create unnecesary conflicts with my own branches at this point.