Skip to content

zernike enable table is saved for each wft. Display diff - #369

Open
atsju wants to merge 2 commits into
masterfrom
JST/152-2
Open

zernike enable table is saved for each wft. Display diff#369
atsju wants to merge 2 commits into
masterfrom
JST/152-2

Conversation

@atsju

@atsju atsju commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This one also improves #152 . We can probably do it differently and with better visuals but it's enough to validate the intent.
Just let me know.

you will notice small + and - before the zernike names.
It makes it much clearer witch zernike have been used to display a given waveform and what would change if hitting compute button.

@atsju
atsju requested review from githubdoe and gr5 August 11, 2026 06:00

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v20.1.2

Have any feedback or feature suggestions? Share it here.

Comment thread surfacemanager.cpp Outdated
@github-actions

Copy link
Copy Markdown

🚀 New build available for commit 96c8467
Download installer here

@github-actions

Copy link
Copy Markdown

🚀 New build available for commit b86941b
Download installer here

@gr5

gr5 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I love this feature! Chef's kiss.

It even keeps track if I select multiple wavefronts, change a zernike checkbox and hit recompute. It properly keeps track of which wavefronts were modified and which weren't.

There is a minor feature/bug however:

If I have 2 wavefronts, one was computed with spherical zernike checked and one without. I can click on the two wavefronts one at a time and I can see which one was calculated with and without. however if I select both wavefronts then it matters which I select last. Should there be a third symbol when it's mixed?

With software installers there are checkboxes that can be checked, unchecked, or there is a 3rd symbol to indicate that some of the sub features are checked and some are not. I don't want to change the checkboxes here but the "+" and "-" symbols perhaps to a third symbol "." or "*".

@gr5

gr5 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Are you going to try to add a third symbol @atsju?

@atsju

atsju commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

yes it sounds like an excellent idea.
I need some time.

more generally, I had in mind to fix lot of little identified issues but at low pace. Just let me know if you have release in mind.

@gr5

gr5 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

I wanted to release this week but now Dale has a new feature and he hasn't done a PR and he may be adding more features so no rush at the moment.

@githubdoe

Copy link
Copy Markdown
Owner

I'm playing and do not have anything to release. When it is ready I want others to test it and decide if it is worth while and the GUI makes sense. So it is a long way away from being a released feature.

@gr5

gr5 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

I thought we could release it as an "experiment" so we can play with it and think about how it should be done "right" and also see what video devices it works with and what ones it doesn't.

Changing the subject a little: because I was testing out doors I found it very useful to average 10-20 wavefronts without moving anything just to get rid of the air current noise. The wavefront would really settle down even with gusts of wind. Without the averaging it was a mess - bouncing around.

This feature might only be useful when you are out doors or if you have a fan running. I don't know. But at Stellafane it was very useful.

So I kind of envision making 10 averages (one wavefront made from 10). Saving one wavefront. Moving tilt, get a new outline, make another 10-igram average. Or alternatively after the first 10-igram average, rotating the mirror by 90 degrees and getting a second 10-igram average.

There is a guy, Charles Wright, who claims he has a rock solid, very useful, outline generator. If we have that as well only then would we likely be able to move the tilt while it's averaging.

I don't think the "blue circle" needs to reach out to the lobes - I have tested a small blue circle and it barely changes the results.

But I'm okay with doing a release next week without the video feature.

@githubdoe

Copy link
Copy Markdown
Owner

There is sort of a paradigm shift with the blue circle when using the live video. You are use to setting the blue circle based on the DFT. With live view we can set a blue circle and then change tilts and defocus to always make the sidelobes at least just outside it. The blue circle helps get rid of low spatial frequency background noise.

Currently when you start the loop it starts showing a running average that contains all the wave fronts since it started. It saves each individual wave front in the wave front list as usual. It does not save the average it just shows it. You can wait watching till the average settles down. Then stop and go over to the wave front list and select them and average them in the usual way. Then you have a real average wave front with as many as you need.

@githubdoe

Copy link
Copy Markdown
Owner

To test it you need either skysolve or a USB camera. You can of course run analsis on any image the USB camera has in it. It will create a surface of some sort. I was surprised to see a surface kind of like the glasses on my face when using my web cam on my face. Many waves of error but setting the y scale to about 100 wave create a flat surface of my glasses outline among a lot of other blotches.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants