Supply chain improvements#26
Merged
Merged
Conversation
Pin third-party workflow actions, run CI on Node 26 with npm ci, and add npm minimum release age configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mocha 10 pulls in yargs 16, which fails under Node 26 when loaded from this type:module package. Update Mocha so the test runner uses a Node 26-compatible yargs release.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR focuses on supply-chain hardening for the project’s npm and CI/release workflows by updating the test toolchain and tightening CI installation/pinning practices.
Changes:
- Upgraded Mocha to a Node 26–compatible version and refreshed the lockfile accordingly.
- Added a project
.npmrcto enforce a minimum package release age during installs. - Updated GitHub Actions workflows to use Node 26, prefer
npm ci, and pin actions to full commit SHAs.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps Mocha to a newer major version to support newer Node in CI. |
| package-lock.json | Updates resolved dependency graph to match the Mocha upgrade. |
| .npmrc | Adds a minimum release age policy for npm installs (supply-chain control). |
| .github/workflows/nodejs.yml | Pins actions, moves CI to Node 26, switches install to npm ci. |
| .github/workflows/publish.yml | Pins actions and moves publishing workflow to Node 26. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/5 changed files
- Comments generated: 1
| @@ -0,0 +1 @@ | |||
| min-release-age=3 | |||
manuelpuyol
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmrcwithmin-release-age=3for npm installs..github/workflows/nodejs.ymlto run Node 26, usenpm ci, and pin third-party actions to full commit SHAs..github/workflows/publish.ymlto run Node 26 and pin third-party actions to full commit SHAs.Ecosystems detected
Recommendations applied
npm ci.id-token: writeand no token-based publish.npm audit fix; no changes were needed before the CI fix.Not applied
Human review notes
npm audit --audit-level=moderatepasses; npm reports two low-severity advisories in Mocha'sdiffdependency with no non-breaking fix currently available.Validation
npm install --save-dev mocha@^11.7.6npm cinpm run build --if-presentnpm testnpm audit --audit-level=moderatenpx -y -p node@26 -c 'node -v && npm run build --if-present && npm test'