Expanding mono vf options#117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mona Sans Mono’s Glyphs sources to expand variable-font export options, primarily by adding new variable instances in fontinfo.plist and adjusting several composite glyph layers’ component positioning/advance widths to align with the intended Mono metrics across masters.
Changes:
- Added additional variable font instances to export weight-only VFs (overall, plus Condensed-only and Expanded-only variants) via
Disable Masters. - Normalized widths and mark component positions for several
Udiacritic composites (includingss01variants) to match the Mono master spacing strategy. - Updated
acaron.ss05component positioning/advance widths in multiple layers to align with the revised Mono metrics.
Show a summary per file
| File | Description |
|---|---|
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresismacron.ss01.glyph | Adjusts component placement and widths for the ss01 composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresismacron.glyph | Adjusts component placement and widths for the composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresisgrave.ss01.glyph | Adjusts component placement and widths for the ss01 composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresisgrave.glyph | Adjusts component placement and widths for the composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresiscaron.ss01.glyph | Adjusts component placement and widths for the ss01 composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresiscaron.glyph | Adjusts component placement and widths for the composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresisacute.ss01.glyph | Adjusts component placement and widths for the ss01 composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/U_dieresisacute.glyph | Adjusts component placement and widths for the composite to match updated Mono metrics. |
| sources/MonaSansMono.glyphspackage/glyphs/acaron.ss05.glyph | Updates caron component placement and layer widths to match the revised Mono metrics. |
| sources/MonaSansMono.glyphspackage/fontinfo.plist | Adds new variable instances (weight-only + width-specific weight-only exports) using Disable Masters. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
sources/MonaSansMono.glyphspackage/fontinfo.plist:1425
- For the
MonaSansMonoVF-Expanded[wght]variable instance, theVariable Font Originis set to master id0B69...(ExtraLight), but this instance disablesExtraLight/Blackmasters. Update the origin to an enabled expanded master id (e.g. Expanded ExtraLight) so the origin isn’t among disabled masters.
name = "Variable Font Origin";
value = "0B69FD92-C08A-4234-9918-6776008DFD7A";
},
- Files reviewed: 10/22 changed files
- Comments generated: 1
Comment on lines
+1389
to
+1392
| name = "Variable Font Origin"; | ||
| value = "0B69FD92-C08A-4234-9918-6776008DFD7A"; | ||
| }, | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to the
U_dieresisacuteglyph and its stylistic set variant, as well as enhancements to the font's variable font configurations. Refinements to the font's variable axes and master settings.