Close SPDD conformance gaps for ADRs 27325/27327/27387/27476/27479

[Copilot]

This PR addresses the SPDD queue gaps for five draft ADRs by adding missing conformance guards/tests and aligning comment-memory/safe-outputs specs with implemented behavior. It also promotes the covered ADRs to Accepted where implementation and verification now match normative requirements.

• Compile-all frontmatter error-handling conformance (ADR-27387)

  • Added coverage for frontmatter-filter I/O failures to ensure read errors are surfaced as compile-time failures rather than silently skipped.
  • File: pkg/cli/commands_file_watching_test.go

• Durable helper-organization guard (ADR-27325)

  • Added a regression test that enforces engine API target helpers stay out of awf_helpers.go and remain in engine_api_targets.go.
  • File: pkg/workflow/engine_api_targets_file_organization_test.go

• Comment-memory prompt-size safeguards (ADR-27479)

  • Added hard caps during pre-agent materialization:
    • per-file cap: 16 KiB
    • aggregate directory cap: 48 KiB
  • Oversized memory now fails setup safely instead of inflating prompt/context size.
  • Files:
    • actions/setup/js/comment_memory_helpers.cjs
    • actions/setup/js/setup_comment_memory_files.cjs
    • actions/setup/js/setup_comment_memory_files.test.cjs

• Safe-outputs needs/spec sync (ADR-27476)

  • Confirmed and documented schema alignment for safe-outputs.needs and added norms/safeguard language for cycle protection + schema/IDE sync expectations.
  • Files:
    • docs/adr/27476-extend-safe-outputs-dependencies-via-needs-field.md
    • docs/src/content/docs/reference/safe-outputs.md
    • pkg/parser/schemas/main_workflow_schema.json (already aligned; documented explicitly)

• ADR status and REASONS completion

  • Promoted ADRs 27325, 27327, 27387, 27476, 27479 from Draft → Accepted.
  • Added missing safeguards/norms and removed stale “draft” footer text in those ADR files.

const COMMENT_MEMORY_MAX_FILE_BYTES = 16 * 1024;
const COMMENT_MEMORY_MAX_TOTAL_BYTES = 48 * 1024;

const contentBytes = Buffer.byteLength(content, "utf8");
if (contentBytes > COMMENT_MEMORY_MAX_FILE_BYTES) {
  throw new Error(`...exceeding max ${COMMENT_MEMORY_MAX_FILE_BYTES} bytes`);
}
totalBytes += contentBytes;
if (totalBytes > COMMENT_MEMORY_MAX_TOTAL_BYTES) {
  throw new Error(`...exceeds max ${COMMENT_MEMORY_MAX_TOTAL_BYTES} bytes`);
}

• Fixes [spdd] Daily spec work plan - 2026-07-23 #47636

---

Run: https://github.com/github/gh-aw/actions/runs/30042541462

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.1 AIC · ⌖ 9.05 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

[github-actions]

🤖 PR Triage

Field	Value
Category	docs
Risk	🟡 Medium
Priority Score	52/100
Recommended Action	batch_review

Score breakdown: Impact 22 + Urgency 15 + Quality 15

Rationale: Draft PR touching ADR docs, conformance specs, JS helpers, and tests for safe-outputs/comment-memory. Moderate scope across multiple subsystems. Groups well with #47633 as a docs/spec batch. No CI data available.

Generated by 🔧 PR Triage Agent · sonnet46 · 38.1 AIC · ⌖ 6.75 AIC · ⊞ 5.7K · ◷

[Copilot]

Pull request overview

Closes SPDD conformance gaps through regression guards, bounded comment-memory materialization, and synchronized ADR/spec documentation.

Changes:

• Adds Go conformance tests for compile-all errors and helper organization.
• Enforces and tests comment-memory size limits.
• Updates specifications and accepts five ADRs.

Show a summary per file

File	Description
pkg/workflow/engine_api_targets_file_organization_test.go	Guards helper placement.
pkg/cli/commands_file_watching_test.go	Tests frontmatter read failures.
actions/setup/js/comment_memory_helpers.cjs	Defines memory-size limits.
actions/setup/js/setup_comment_memory_files.cjs	Enforces memory limits.
actions/setup/js/setup_comment_memory_files.test.cjs	Tests oversized-memory handling.
docs/src/content/docs/specs/safe-outputs-specification.md	Specifies memory safeguards.
docs/src/content/docs/reference/safe-outputs.md	Documents schema integration.
docs/adr/27325-organize-workflow-helpers-by-semantic-responsibility.md	Accepts helper-organization ADR.
docs/adr/27327-parser-utility-test-strategy.md	Accepts parser-testing ADR.
docs/adr/27387-filter-non-frontmatter-markdown-during-compile-all.md	Accepts compile-all filtering ADR.
docs/adr/27476-extend-safe-outputs-dependencies-via-needs-field.md	Adds safeguards and accepts ADR.
docs/adr/27479-comment-memory-file-based-agent-memory-with-github-persistence.md	Adds size norms and accepts ADR.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

docs/adr/27476-extend-safe-outputs-dependencies-via-needs-field.md:80

• This normative statement names a validator that cannot inspect safe-outputs.needs: detectSafeJobCycles only traverses custom jobs under safe-outputs.jobs, and it runs before job assembly. Require the full JobManager.ValidateDependencies pass instead, which is the existing gate that can detect cycles involving the consolidated job.

1. Safe-output custom job cycle detection **MUST** continue to run after `safe-outputs.needs` merge/validation so that new dependency edges cannot introduce cycles.

• Files reviewed: 12/12 changed files
• Comments generated: 5
• Review effort level: Medium

[gh-aw-bot]

@copilot please run the pr-finisher skill, address unresolved review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.1 AIC · ⌖ 9.05 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}