Strengthen frontmatter YAML helper tests with table-driven coverage and injection guards

[Copilot]

pkg/workflow/frontmatter_extraction_yaml_test.go previously covered only one helper with a single t.Fatal check. This update expands coverage across core pure helpers in frontmatter_extraction_yaml.go, standardizes on testify assertions with messages, and adds explicit regression checks for expression-injection-shaped inputs.

• isGitHubAppNestedField: full table-driven coverage

  • Replaced t.Fatal path with assert.Equal/assert-style checks.
  • Added cases for all supported named fields (app-id, client-id, private-key, ignore-if-missing, owner, repositories), repository list items (- ...), and non-matching/near-miss keys.

• Workflow run conclusion validation hardening

  • Added TestIsValidWorkflowRunConclusion covering all allowed conclusions.
  • Added negative cases for unknown values and injection-attempt strings.

• indentYAMLLines behavior contract

  • Added table-driven tests for empty input, single-line input, multi-line indentation, and blank-line preservation semantics.

• Condition-extraction helper coverage

  • Added TestExtractDeploymentStatusStateCondition for missing config, single/multi-state inputs, and mixed-type arrays (string filtering behavior).
  • Added TestExtractWorkflowRunConclusionConditionHelper for missing config, valid single/multi conclusions, and invalid/injection conclusion rejection via error path.

tests := []struct {
    name       string
    conclusion string
    want       bool
}{
    {name: "success", conclusion: "success", want: true},
    {name: "timed_out", conclusion: "timed_out", want: true},
    {name: "expression injection attempt", conclusion: "success' || contains(github.event.comment.body, 'x') || '", want: false},
}
for _, tt := range tests {
    t.Run(tt.name, func(t *testing.T) {
        assert.Equal(t, tt.want, isValidWorkflowRunConclusion(tt.conclusion),
            "isValidWorkflowRunConclusion(%q) should return %t", tt.conclusion, tt.want)
    })
}

[Copilot]

Pull request overview

Expands the previously thin frontmatter_extraction_yaml_test.go with table-driven tests for several pure helpers in frontmatter_extraction_yaml.go, standardizes on testify assertions, and adds regression cases for expression-injection-shaped inputs (notably for workflow_run.conclusion).

Changes:

• Adds table-driven coverage for isGitHubAppNestedField, isValidWorkflowRunConclusion, and indentYAMLLines.
• Adds TestExtractDeploymentStatusStateCondition and TestExtractWorkflowRunConclusionConditionHelper, including injection-attempt rejection.
• Switches to testify assert style with descriptive messages, replacing the prior single t.Fatal check.

Show a summary per file

File	Description
pkg/workflow/frontmatter_extraction_yaml_test.go	Greatly expanded tests for frontmatter YAML helpers; contains a stray ) that breaks compilation.
.github/workflows/daily-model-inventory.lock.yml	Regenerated lock metadata (body_hash bump only); no functional change.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1

[pelikhan]

@copilot review all comments

[Copilot]

@copilot review all comments

Addressed in b8c6983. I reviewed the actionable feedback, fixed the malformed loop closures in pkg/workflow/frontmatter_extraction_yaml_test.go, and verified with go test ./pkg/workflow -count=1.