[log] Add debug logging to rate_limit.go#6870
Merged
Merged
Conversation
Add meaningful logCircuitBreaker debug calls to the three functions in rate_limit.go that previously had no logging: - extractRateLimitErrorText: log when result is not a map, when scanning content items, and when no text is found (fallback path) - isRateLimitToolResult: log the number of content items being inspected when an error result is encountered - parseRateLimitResetFromText: log when the reset time pattern is absent from the error text Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves observability of the server-side rate limit detection flow by adding additional logCircuitBreaker debug logging in internal/server/rate_limit.go, helping diagnose unexpected tool result shapes and why reset timestamps aren’t being inferred.
Changes:
- Add debug logging when
extractRateLimitErrorTextreceives an unexpected (non-map) result and when it falls back to the default message. - Add debug logging showing how many content items are scanned in
extractRateLimitErrorText/isRateLimitToolResult. - Add debug logging when
parseRateLimitResetFromTextdoes not find the"rate reset in "pattern.
Show a summary per file
| File | Description |
|---|---|
| internal/server/rate_limit.go | Adds debug log lines around error-text extraction, rate-limit tool-result inspection, and reset-time parsing fallback paths. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful
logCircuitBreakerdebug calls to the functions ininternal/server/rate_limit.gothat previously had no logging coverage.Changes
extractRateLimitErrorText: logs when the result is not a map (unexpected input), when scanning content items (with count), and when the fallback default message is usedisRateLimitToolResult: logs the number of content items being inspected when an error result is encounteredparseRateLimitResetFromText: logs when the"rate reset in Ns"pattern is absent from the error textAll new log calls use the existing
logCircuitBreakerlogger (declared incircuit_breaker.go, same package) — no new logger declaration needed.Quality checklist
logCircuitBreakerlogger (no duplicate declaration)pkg:filenameconvention (existing:server:circuit_breaker)go buildpassesgo test ./...passesgo vet ./...passesWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.