Skip to content

[Test Coverage] src/docker-manager.ts - #6817

Merged
lpcox merged 1 commit into
mainfrom
test-coverage/docker-manager-8ff5dbad92aa3803
Aug 1, 2026
Merged

[Test Coverage] src/docker-manager.ts#6817
lpcox merged 1 commit into
mainfrom
test-coverage/docker-manager-8ff5dbad92aa3803

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a dedicated Jest test suite for src/docker-manager.ts, a barrel/re-export module (24 lines) that surfaces the public API from host-env.ts, config-writer.ts, container-lifecycle.ts, and container-cleanup.ts. Those underlying modules already have dedicated, well-covered test suites, but the barrel module itself had 0% direct test coverage.

Changes

  • New file: src/docker-manager.test.ts
  • Verifies every re-exported symbol (setAwfDockerHost, getLocalDockerEnv, parseDifcProxyHost, writeConfigs, startContainers, runAgentCommand, fastKillAgentContainer, collectDiagnosticLogs, stopContainers, preserveIptablesAudit, cleanup) is present and is a function.
  • Asserts the barrel's export surface exactly matches the expected set (guards against accidental removal/addition of exports).

Testing

./node_modules/.bin/jest --testPathPatterns="^src/docker-manager\.test\.ts$" --no-coverage

Result: 5 passed, 5 total.

No Docker/iptables calls are made — this suite only exercises the module's export statements.

Generated by Test Coverage Improver · aut00 · 29.4 AIC · ⊞ 9K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox
lpcox marked this pull request as ready for review August 1, 2026 22:24
Copilot AI review requested due to automatic review settings August 1, 2026 22:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds direct Jest coverage for the docker-manager compatibility barrel.

Changes:

  • Verifies all expected function re-exports.
  • Guards the exact public export surface.
Show a summary per file
File Description
src/docker-manager.test.ts Tests barrel exports and their function shape.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

🚀 Security Guard has started processing this pull request

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Claude passed

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Build Test Suite completed successfully!

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

🔌 Smoke Services — All services reachable! ✅

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Gemini completed. All facets verified. 💎

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Contribution Check completed successfully!

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (github.com) reachable: allowed=200
✅ Blocked domain (example.com) denied: CONNECT tunnel failed, 403

Overall status: PASS

@lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
Add label ready-for-aw to run again

@github-actions github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Test: Copilot Engine@lpcox

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Test: Copilot BYOK (Direct) Mode

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

Overall: PASS

cc @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Test: Claude Engine Validation

Check Result
API status ✅ PASS
gh check ✅ PASS
File status ✅ PASS

Overall result: PASS

Generated by Smoke Claude for #6817 · haiku45 · 55.4 AIC · ⊞ 3.6K ·
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Test Results

  • Redis PING: ❌ (DNS resolution failure for host.docker.internal)
  • PostgreSQL pg_isready: ❌ (no response, DNS failure)
  • PostgreSQL SELECT 1: ❌ (DNS resolution failure)

Overall: FAIL

All checks failed due to Temporary failure in name resolution for host.docker.internal. No smoke-services label applied.

🔌 Service connectivity validated by Smoke Services
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Gemini Smoke Test Results

  • GitHub MCP Testing: ❌ (Access Denied by Secrecy Policy)
  • GitHub.com Connectivity: ✅ (200 via proxy)
  • File Writing: ✅
  • Bash Tool: ✅

Overall Status: FAIL

💎 Faceted by Smoke Gemini
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Test: API Proxy OTEL Tracing — Results

  • S1 Module Loading: ✅ otel.js loads successfully. Exports: startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled, plus internal exporter helpers.
  • S2 Test Suite: ✅ otel.test.js + otel-fanout.test.js — 59/59 tests passed.
  • S3 Env Var Forwarding: ❌ src/services/api-proxy-service.ts does not reference OTEL_EXPORTER_OTLP_ENDPOINT or GITHUB_AW_OTEL_TRACE_ID — OTEL config is not forwarded to the api-proxy container.
  • S4 Token Tracker Integration: ✅ onUsage callback present in token-tracker-http.js (used as the OTEL hook point after normalized usage extraction).
  • S5 OTEL Diagnostics: ⚠️ /tmp/gh-aw/otel.jsonl contains only 1 span (gh-aw.agent.setup, the workflow's own tracing) — no spans originating from the api-proxy sidecar were exported, consistent with the S3 gap.

Summary: 3/5 pass, 1 real gap (S3/S5 — api-proxy container never receives OTEL env vars, so it can't emit its own spans), module loading and test coverage otherwise solid. Filing an issue to track the env var forwarding gap.

📡 OTel tracing validated by Smoke OTel Tracing
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.13 ✅ YES
Node.js v24.18.0 v22.23.1 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: FAILED — Node.js version mismatch between host and chroot environment. smoke-chroot label not applied since not all tests passed.

Tested by Smoke Chroot
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A (run OK) ✅ PASS
.NET json-parse N/A (run OK) ✅ PASS
Go color pass ✅ PASS
Go env pass ✅ PASS
Go uuid pass ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx pass ✅ PASS
Node.js execa pass ✅ PASS
Node.js p-limit pass ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — PASS

Note: Java Maven builds required overriding localRepository to a writable path (/tmp/gh-aw/agent/m2repo) since ~/.m2/repository was not writable by the runner user; only the proxy settings (squid-proxy:3128) came from the task instructions.

Generated by Build Test Suite for #6817 · auto · 50.6 AIC · ⊞ 11.4K ·
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Docker Sbx Smoke Test

✅ GitHub MCP connectivity (list_pull_requests responded)
✅ github.com connectivity (HTTP 200)
✅ File write/read test passed

Recent merged PRs: #6820 Upgrade gh-aw extension to latest pre-release (v0.84.2); #6805 Deduplicate bounded-query runtime preflight checks behind a shared policy dispatcher

Overall: PASS

cc @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
Add label ready-for-aw to run again

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Merged PRs reviewed:

  • fix(ai-credits): allow Copilot auto model through the AI-credits pre-flight guard
  • Upgrade gh-aw extension to latest pre-release (v0.84.2)

Checks:

  • PR list: ✅
  • GitHub title: ✅
  • Smoke file: ✅
  • Build: ❌

Overall: FAIL

🔮 The oracle has spoken through Smoke Codex
Add label ready-for-aw to run again

@lpcox
lpcox merged commit eeddbcc into main Aug 1, 2026
136 of 140 checks passed
@lpcox
lpcox deleted the test-coverage/docker-manager-8ff5dbad92aa3803 branch August 1, 2026 22:48
@github-actions github-actions Bot mentioned this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants