[Test Coverage] src/docker-manager.ts - #6817
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds direct Jest coverage for the docker-manager compatibility barrel.
Changes:
- Verifies all expected function re-exports.
- Guards the exact public export surface.
Show a summary per file
| File | Description |
|---|---|
src/docker-manager.test.ts |
Tests barrel exports and their function shape. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🚀 Security Guard has started processing this pull request |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Smoke Claude passed |
|
✅ Build Test Suite completed successfully! |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
🔌 Smoke Services — All services reachable! ✅ |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✅ Contribution Check completed successfully! |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall status: PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
Smoke Test: Copilot Engine —
Overall: PASS
|
Smoke Test: Copilot BYOK (Direct) Mode
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com Overall: PASS cc
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
Smoke Test Results
Overall: FAIL All checks failed due to
|
Gemini Smoke Test Results
Overall Status: FAIL
|
Smoke Test: API Proxy OTEL Tracing — Results
Summary: 3/5 pass, 1 real gap (S3/S5 — api-proxy container never receives OTEL env vars, so it can't emit its own spans), module loading and test coverage otherwise solid. Filing an issue to track the env var forwarding gap.
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version mismatch between host and chroot environment.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Note: Java Maven builds required overriding
|
|
Docker Sbx Smoke Test ✅ GitHub MCP connectivity (list_pull_requests responded) Recent merged PRs: #6820 Upgrade gh-aw extension to latest pre-release (v0.84.2); #6805 Deduplicate bounded-query runtime preflight checks behind a shared policy dispatcher Overall: PASS cc
|
|
Merged PRs reviewed:
Checks:
Overall: FAIL
|
Summary
Adds a dedicated Jest test suite for
src/docker-manager.ts, a barrel/re-export module (24 lines) that surfaces the public API fromhost-env.ts,config-writer.ts,container-lifecycle.ts, andcontainer-cleanup.ts. Those underlying modules already have dedicated, well-covered test suites, but the barrel module itself had 0% direct test coverage.Changes
src/docker-manager.test.tssetAwfDockerHost,getLocalDockerEnv,parseDifcProxyHost,writeConfigs,startContainers,runAgentCommand,fastKillAgentContainer,collectDiagnosticLogs,stopContainers,preserveIptablesAudit,cleanup) is present and is a function.Testing
Result: 5 passed, 5 total.
No Docker/iptables calls are made — this suite only exercises the module's export statements.