Skip to content

Replace ncc with esbuild #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 1 commit into from
Aug 11, 2026
Merged

Replace ncc with esbuild #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ output/output.json
repo
tmp/

# Ignore optional native extensions for SSH
dist/*/build/Release/cpufeatures.node
dist/*/lib/protocol/crypto/build/Release/sshcrypto.node

@jeffwidman jeffwidman Aug 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be safely ignored because they are no longer generated, they're skipped via passing the --loader:.node=empty flag to esbuild


# Dependency directory
node_modules

Expand Down
9 changes: 3 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ Note: If you do not execute the above step ☝️ and commit the code then CI wi
```bash
Run script/check-diff
Detected uncommitted changes after build:
diff --git a/dist/main/index.js b/dist/main/index.js
index c09ccea..8f50b37 1006[4](https://github.com/github/dependabot-action/actions/runs/7720200685/job/21044694134?pr=1156#step:7:5)4
Binary files a/dist/main/index.js and b/dist/main/index.js differ
diff --git a/dist/main/index.js.map b/dist/main/index.js.map
index cc44481..e[5](https://github.com/github/dependabot-action/actions/runs/7720200685/job/21044694134?pr=1156#step:7:6)0840f 100[6](https://github.com/github/dependabot-action/actions/runs/7720200685/job/21044694134?pr=1156#step:7:7)44
Binary files a/dist/main/index.js.map and b/dist/main/index.js.map differ
diff --git a/dist/main.js b/dist/main.js
index c09ccea..8f50b37 100644
Binary files a/dist/main.js and b/dist/main.js differ
```

3. Commit and push the code changes
Expand Down
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ description: 'Runs dependabot-updater in Actions'
author: 'GitHub'
runs:
using: 'node24'
main: 'dist/main/index.js'
post: 'dist/cleanup/index.js'
main: 'dist/main.js'
post: 'dist/cleanup.js'
Loading
Loading