Skip to content

Add repository-wide TypeScript typecheck - #1754

Merged
jeffwidman merged 1 commit into
mainfrom
add-typecheck-ci
Aug 10, 2026
Merged

Add repository-wide TypeScript typecheck#1754
jeffwidman merged 1 commit into
mainfrom
add-typecheck-ci

Conversation

@jeffwidman

@jeffwidman jeffwidman commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • make the root TypeScript project cover both source and test files
  • use that project for ESLint and remove the redundant ESLint-only configuration
  • add a typecheck script using tsc --noEmit
  • run typechecking in the main test workflow after the fast formatting check

This matches the explicit typecheck used by dependabot/fetch-metadata. Neither ncc nor a future esbuild migration provides semantic TypeScript checking.

TypeScript configuration

The root tsconfig.json previously included only src/**/*.ts. Because ESLint uses type-aware rules and also lints files under __tests__/, tsconfig.eslint.json was added to extend the root configuration with both source and test files.

This PR makes the root configuration the canonical repository-wide TypeScript project by including both directories there. TypeScript, ESLint, editors, and CI can therefore use the same project, and the ESLint-specific configuration is no longer needed. Packaging remains scoped by the explicit ncc entry points, so including tests in the TypeScript project does not add them to the production bundles. The same remains true for a future esbuild migration.

Validation

  • npm run format-check
  • npm run typecheck
  • npm run lint-check
  • GITHUB_ACTOR=github-actions GITHUB_EVENT_NAME=pull_request npm test -- --runInBand
  • npm run package

Copilot AI balanced review requested due to automatic review settings August 10, 2026 20:18
@jeffwidman
jeffwidman requested a review from a team as a code owner August 10, 2026 20:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit TypeScript project type-checking to CI, covering source and test files without emitting output.

Changes:

  • Adds an npm run typecheck script.
  • Runs type-checking in the main test workflow.
Show a summary per file
File Description
package.json Defines the TypeScript type-check command.
.github/workflows/test.yml Executes type-checking during CI.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@jeffwidman jeffwidman changed the title Add TypeScript typecheck to CI Add repository-wide TypeScript typecheck Aug 10, 2026
@jeffwidman
jeffwidman merged commit 0cc82c1 into main Aug 10, 2026
11 checks passed
@jeffwidman
jeffwidman deleted the add-typecheck-ci branch August 10, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants