Add repository-wide TypeScript typecheck - #1754
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit TypeScript project type-checking to CI, covering source and test files without emitting output.
Changes:
- Adds an
npm run typecheckscript. - Runs type-checking in the main test workflow.
Show a summary per file
| File | Description |
|---|---|
package.json |
Defines the TypeScript type-check command. |
.github/workflows/test.yml |
Executes type-checking during CI. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
jeffwidman
force-pushed
the
add-typecheck-ci
branch
from
August 10, 2026 20:35
5eeccb6 to
961b9e9
Compare
jeffwidman
force-pushed
the
add-typecheck-ci
branch
from
August 10, 2026 20:42
961b9e9 to
1142035
Compare
ruben-pachecocaldera
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecheckscript usingtsc --noEmitThis matches the explicit typecheck used by
dependabot/fetch-metadata. Neither ncc nor a future esbuild migration provides semantic TypeScript checking.TypeScript configuration
The root
tsconfig.jsonpreviously included onlysrc/**/*.ts. Because ESLint uses type-aware rules and also lints files under__tests__/,tsconfig.eslint.jsonwas added to extend the root configuration with both source and test files.This PR makes the root configuration the canonical repository-wide TypeScript project by including both directories there. TypeScript, ESLint, editors, and CI can therefore use the same project, and the ESLint-specific configuration is no longer needed. Packaging remains scoped by the explicit ncc entry points, so including tests in the TypeScript project does not add them to the production bundles. The same remains true for a future esbuild migration.
Validation
npm run format-checknpm run typechecknpm run lint-checkGITHUB_ACTOR=github-actions GITHUB_EVENT_NAME=pull_request npm test -- --runInBandnpm run package