python: make generated package private - #2202
Open
omidsaffari wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
copilot.generateddocuments itself as an internal implementation package, but its public-looking name does not follow Python's underscore convention for private modules.What
copilot._generatedand update internal imports.copilot.rpcandcopilot.session_eventsentry points and their current exports unchanged.This intentionally does not curate or otherwise change the existing generated export lists.
The mistakenly exposed
copilot.generatedimport path is removed. Consumers should use the documentedcopilot.rpcandcopilot.session_eventsmodules instead.Fixes #2048
Validation
uv run pytest --ignore=e2e -q— 326 passeduv run pytest test_public_api.py test_codegen_type_names.py test_event_forward_compatibility.py test_tools.py test_rpc_generated.py -q— 64 passeduv run ruff format --check .uv run ruff check .uv run ty check copilot— exits successfully with the two diagnostics already present onmaincopilot._generated,copilot.rpc, andcopilot.session_events, with nocopilot.generatedpackage