C++: Upgrade cpp/comparison-with-wider-type to high precision#21634
Merged
geoffw0 merged 4 commits intogithub:mainfrom Apr 10, 2026
Merged
C++: Upgrade cpp/comparison-with-wider-type to high precision#21634geoffw0 merged 4 commits intogithub:mainfrom
geoffw0 merged 4 commits intogithub:mainfrom
Conversation
Contributor
Author
|
DCA, QA LGTM. Bringing out of draft. |
jketema
approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the C++ query cpp/comparison-with-wider-type to high precision, which makes it eligible to run in the default C++ code scanning suite, and documents the change.
Changes:
- Updated the query metadata for
cpp/comparison-with-wider-typefrom@precision mediumto@precision high. - Added a change note announcing the precision upgrade and default-suite inclusion impact.
- Updated the expected contents of the C++ code scanning query suite to include the query.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/src/Security/CWE/CWE-190/ComparisonWithWiderType.ql | Changes query metadata to @precision high. |
| cpp/ql/src/change-notes/2026-04-02-comparison-with-wider-type.md | Adds release note for the precision upgrade and suite impact. |
| cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected | Updates expected default code scanning suite contents to include the query. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
cpp/comparison-with-wider-typeto@precision high(following multiple rounds of testing).