Skip to content

C++: Upgrade cpp/integer-multiplication-cast-to-long to high precision#21633

Merged
geoffw0 merged 3 commits intogithub:mainfrom
geoffw0:intmultlong2
Apr 10, 2026
Merged

C++: Upgrade cpp/integer-multiplication-cast-to-long to high precision#21633
geoffw0 merged 3 commits intogithub:mainfrom
geoffw0:intmultlong2

Conversation

@geoffw0
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 commented Apr 2, 2026

Upgrade cpp/integer-multiplication-cast-to-long to @precision high (following improvement and multiple rounds of testing).

@geoffw0
Copy link
Copy Markdown
Contributor Author

geoffw0 commented Apr 10, 2026

DCA, QA LGTM. Bringing out of draft.

@geoffw0 geoffw0 marked this pull request as ready for review April 10, 2026 12:56
@geoffw0 geoffw0 requested a review from a team as a code owner April 10, 2026 12:56
Copilot AI review requested due to automatic review settings April 10, 2026 12:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the CodeQL C++ query cpp/integer-multiplication-cast-to-long to high precision so it can run in the default C++ code scanning suite.

Changes:

  • Updated query metadata to @precision high.
  • Added a change note documenting the precision upgrade.
  • Updated the expected default code scanning query suite to include the query.
Show a summary per file
File Description
cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql Raises query metadata precision from medium to high.
cpp/ql/src/change-notes/2026-04-02-integer-multiplication-cast-to-long.md Documents the precision upgrade and default suite inclusion.
cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected Reflects inclusion of the query in the default code scanning suite.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@geoffw0
Copy link
Copy Markdown
Contributor Author

geoffw0 commented Apr 10, 2026

🎉

@geoffw0 geoffw0 merged commit b9226a3 into github:main Apr 10, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants