fix(website): constrain resource detail content on mobile (#2828) - #2833
Closed
LuckTerence wants to merge 1 commit into
Closed
fix(website): constrain resource detail content on mobile (#2828)#2833LuckTerence wants to merge 1 commit into
LuckTerence wants to merge 1 commit into
Conversation
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
the
needs-review:MEDIUM
Contributor
|
We've got a complete design overhaul coming in #2703 so I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2828
Root cause
On <=900px viewports the detail layout collapses to a single column declared as
grid-template-columns: 1fr. A bare1frtrack has anautominimum, so a widepre/long unbreakable text sizes the track beyond the viewport and the content is clipped at the right edge (the desktop rule already usesminmax(0, 1fr), which is why only mobile is affected).Fix
.detail-layout:minmax(0, 1fr)so the track can shrink and.article-content pre's existingoverflow-x: autoactually kicks in (code blocks scroll horizontally instead of clipping).article-content:min-width: 0+overflow-wrap: break-wordso long text/URLs wrap within the viewportApplies to all resource detail pages (extensions, plugins, agents, instructions, skills) since they share
.detail-layout/.article-content. No markup changes; the CI preview deploy should show the corrected mobile rendering.