Skip to content

fix(pm-skills): use plain tag name for ref, not refs/tags/#1771

Merged
aaronpowell merged 2 commits into
github:stagedfrom
Avyayalaya:fix/pm-skills-ref-format
May 28, 2026
Merged

fix(pm-skills): use plain tag name for ref, not refs/tags/#1771
aaronpowell merged 2 commits into
github:stagedfrom
Avyayalaya:fix/pm-skills-ref-format

Conversation

@Avyayalaya
Copy link
Copy Markdown

Single-line fix in plugins/external.json for the pm-skills entry. The source.ref was refs/tags/v2.1.0 (inherited from the external-plugin issue form's placeholder example). APM invokes git clone --branch=<ref> against the source repo, which rejects the refs/tags/ prefix:

fatal: Remote branch refs/tags/v2.1.0 not found in upstream origin

Other entries in this file use plain tag names (chrome-devtools-pluginchrome-devtools-mcp-v1.0.1) or SHAs (ai-ready, sonarqube); pm-skills was the only entry with the refs/tags/ prefix.

Test

After this fix:

apm marketplace add github/awesome-copilot
apm install pm-skills@awesome-copilot --target claude
# → 12 skills + MCP server + 2 hooks integrated in ~35s

Original submission: #1767 / merged-PR #1770.

Note for the issue-form template: the placeholder example reads refs/tags/v1.2.3 or 0123456789abcdef.... The refs/tags/ form is technically a valid git ref but doesn't survive the git clone --branch round-trip APM uses. Worth either changing the placeholder or normalizing the ref in intake validation — happy to send a follow-up PR if helpful.

🤖 Generated with Claude Code

@Avyayalaya Avyayalaya requested a review from aaronpowell as a code owner May 20, 2026 03:28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR targets main, but PRs should target staged.

The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.

You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1771 --base staged

@github-actions github-actions Bot added external-plugin PR updates plugins/external.json plugin PR touches plugins targets-main PR targets main instead of staged labels May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk label May 20, 2026
@Avyayalaya Avyayalaya force-pushed the fix/pm-skills-ref-format branch from 90bcf30 to 2763d40 Compare May 20, 2026 03:32
@Avyayalaya
Copy link
Copy Markdown
Author

Force-pushed a clean version of the branch — the previous diff included Unicode encoding artifacts on three other entries (ai-ready, microsoft-events, whatidid) caused by a Python JSON re-encode pass on my end. Fixed with a surgical sed edit; the diff is now a single one-line change to the pm-skills ref. Apologies for the noise.

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@Avyayalaya Avyayalaya changed the base branch from main to staged May 20, 2026 03:39
@Avyayalaya Avyayalaya requested a review from dvelton as a code owner May 20, 2026 03:39
@github-actions github-actions Bot added branched-main PR appears to include plugin files materialized from main and removed targets-main PR targets main instead of staged plugin PR touches plugins labels May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

`apm install pm-skills@awesome-copilot` invokes `git clone --depth=1 --branch=<ref>` against the source repo. `git clone --branch` rejects `refs/tags/v2.1.0` ("Remote branch not found in upstream origin") and only accepts the plain tag name.

Matches the convention used by the other entries in this file - `chrome-devtools-plugin` uses `chrome-devtools-mcp-v1.0.1`, `ai-ready` uses a SHA. `pm-skills` was the only entry with the `refs/tags/` prefix, inherited from the placeholder example in the external-plugin issue form.

Tested locally: with the fix applied, `apm install pm-skills@awesome-copilot --target claude` resolves cleanly (12 skills + MCP server + 2 hooks integrated).

Original submission: github#1767 / github#1770
@Avyayalaya Avyayalaya force-pushed the fix/pm-skills-ref-format branch from 2763d40 to 7fbf75a Compare May 27, 2026 04:16
@github-actions github-actions Bot added plugin PR touches plugins and removed branched-main PR appears to include plugin files materialized from main labels May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

The previous force-push (7fbf75a) updated plugins/external.json only.
.github/plugin/marketplace.json is a derived artifact regenerated by
`npm start` and must be kept in sync. The Validate README.md workflow
detected the mismatch and failed.

Ran `npm ci && npm start` locally; produces a single 1-line update to
marketplace.json matching the plugins/external.json change.
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@aaronpowell aaronpowell merged commit 2f47529 into github:staged May 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-plugin PR updates plugins/external.json needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk plugin PR touches plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants