Address awesome-copilot review comments in course content - #1
Merged
Conversation
Reworks the permission story away from full YOLO mode and fixes the grammar, path, and safety issues raised in review of the Learning Hub mirror PR (github/awesome-copilot#2800). - Module 1: document that approvals persist in permissions-config.json and can be pre-approved with --allow-tool; note the course codespace ships pre-approved local tools - Modules 5/6/7: replace `copilot --yolo` launches with plain `copilot` (Module 5 uses `--allow-tool playwright`) plus a consistent lead-in explaining the codespace's scoped, pre-approved local tools - Module 0: add the "Include all branches" template step so the start-of-module catch-up branches are copied - Module 4: pin the hook script download to an immutable commit and add curl --fail; drop the stray parenthesis - Module 7: remove the auto-merge instruction in favor of a human review gate; fix the malformed steps list, article, verb agreement, and colon - Module 2: correct the repo-scoped skills path to .github/skills/ - Fix duplicated articles and grammar in Modules 2 and 6 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0214c7e-f75b-4aa8-991d-277a9d941cc4
There was a problem hiding this comment.
Pull request overview
This PR updates the course modules in content/ to address review feedback from the Learning Hub mirror PR, primarily tightening the permission model (removing --yolo), pinning mutable references, and fixing a set of instruction/grammar/path issues so the next sync carries corrected guidance.
Changes:
- Reworks Copilot CLI permission guidance across modules to rely on scoped, pre-approved local tools (and targeted
--allow-tool) rather thancopilot --yolo. - Pins the lifecycle hook script download to an immutable commit and adds
curl --fail. - Fixes multiple content issues (repo-scoped skills path, list formatting, and assorted grammar/spelling/punctuation).
Show a summary per file
| File | Description |
|---|---|
content/00-prerequisites.md |
Adds the template “Include all branches” step so start-of-module-* catch-up branches are copied into learners’ forks. |
content/01-working-with-copilot-cli.md |
Documents how “don’t ask again” permissions persist and how to pre-approve tools with --allow-tool. |
content/02-building-ai-infrastructure.md |
Corrects the repo-scoped skills directory path to .github/skills/ and cleans up wording. |
content/04-lifecycle-hooks.md |
Pins the hook script download to a specific commit and adds curl --fail; fixes a stray punctuation issue. |
content/05-add-feature-barcode.md |
Replaces YOLO guidance with scoped pre-approval for Playwright via --allow-tool playwright. |
content/06-modernize-apps.md |
Removes --yolo usage and fixes multiple phrasing/grammar issues; adds consistent pre-approved-tools guidance. |
content/07-manage-infrastructure.md |
Removes --yolo, adds a human review gate for generated infra PRs, and fixes list/punctuation issues. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 7/7 changed files
- Comments generated: 5
- Review effort level: Lite
- Convert the pre-approved-tools notes in Modules 6 and 7 to plain paragraphs so each section keeps at most one admonition - Tighten the pre-approved-tools wording across Modules 5, 6, and 7 (remove "to be able to"/"being able to" redundancy, add missing comma) - Module 7: declare `text` on the MCP-server prompt code fence - Module 0: use the existing `[contoso-inventory]` reference-style link Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0214c7e-f75b-4aa8-991d-277a9d941cc4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review of the Learning Hub mirror PR (github/awesome-copilot#2800) surfaced a set of issues in the source course content: the permission story leaned on full YOLO mode, a hook script was fetched from a mutable branch, one exercise told the agent to auto-merge generated infrastructure code, and there were assorted grammar, spelling, and path errors. This PR fixes all of them at the source so the next content sync carries the corrections into the mirror.
The headline change is the permission rework. Instead of launching
copilot --yolo, the course now relies on the codespace pre-approving a scoped set of local tools (file writes, builds, local git) while still prompting for anything that spends GitHub credentials or reaches the network. Module 1 explains where those approvals live (permissions-config.json) and how to pre-approve with--allow-tool, and Modules 5, 6, and 7 get a consistent lead-in describing the pre-approved-tools model. The devcontainer that actually seeds those approvals is handled separately ingithub-samples/contoso-inventory.Related Issue
N/A
Type of Change
Changes Made
permissions-config.jsonand can be pre-approved at launch with--allow-tool; note the course codespace ships a pre-approved set of local tools.copilot --yolowith plaincopilot(Module 5 uses--allow-tool playwright), each with a shared lead-in explaining the codespace's scoped, pre-approved local tools.start-of-module-*catch-up branches are copied.curl --fail; remove a stray closing parenthesis..github/skills/; remove a duplicated article.Checklist
Additional Notes
The Playwright MCP command in Module 5 is intentionally left at
@latest(the reviewer suggested pinning; we opted to keep it current). Thestart-of-moduletemplate step depends ongithub-samples/contoso-inventorybeing a public template repo, which is now configured.