fix: resolve {build_dir} in translated pages - #2198
Merged
Merged
Conversation
yangzhg
changed the title
Contributor
Author
|
@dscho Could you please review this PR? Thanks! |
dscho
requested changes
Aug 29, 2026
Translated documents are stored below a language directory. Ordinary
includes are relative to the including file, while {build_dir} points
to that language directory.
Keep the directory from the initial document while recursively expanding
includes and use it only when {build_dir} is present.
Fixes git#2197
Signed-off-by: Yang Zhengguo <yangzhgg@gmail.com>
yangzhg
force-pushed
the
fix/l10n-build-dir-includes
branch
from
August 31, 2026 03:29
781aa13 to
e7b87ae
Compare
Contributor
Author
|
@dscho I addressed the review comments and updated the commit. Could you take another look? |
This comment was marked as spam.
This comment was marked as spam.
dscho
approved these changes
Aug 31, 2026
dscho
left a comment
dscho
left a comment
Member
There was a problem hiding this comment.
Nice! Thank you for addressing my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translated manual page updater leaves
{build_dir}in include paths, so the command lists are replaced by missing-file warnings.Resolve those includes from the language directory. Regular relative includes still use the directory of the source file.
I checked the current
git-html-l10ndata fores,fr,pt_BR,ru,sv,uk, andzh_HANS-CN, including nestedconfig/merge.adocfiles where available. The legacy.txtpath still works as well.Fixes #2197