Repository navigation
Conversation
The Maven handler cached only .jar, .war, .ear, .pom, .aar, .klib and
.module files, so distributions published as archives, such as
apache-maven-{version}-bin.tar.gz, were proxied uncached on every request.
.zip, .tar.gz, .tgz, .tar.bz2 and .tar.xz files now go through the artifact
cache like other artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Maven handler caches only
.jar,.war,.ear,.pom,.aar,.kliband.modulefiles. Everything else goes toproxyUpstream, uncached, so distributions published as archives on Maven Central, such asorg/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.tar.gz, are fetched from upstream on every request.This adds
.zip,.tar.gz,.tgz,.tar.bz2and.tar.xzto the artifact extensions. They take the same path as jars, including the Gradle Plugin Portal fallback, and are listed under theirgroup:artifactname. Checksums and signatures (.tar.gz.sha512etc.) still matchisMetadataFilefirst, so they're unchanged.Tested with
go test ./...andgolangci-lint run ./...(v2.13.1, 0 issues), and by running the proxy against Maven Central: the first fetch ofapache-maven-3.9.9-bin.tar.gztook 1.7s, the second 16ms from cache, and/api/search?ecosystem=mavenlistsorg.apache.maven:apache-maven.