Log actual database config instead of sqlite path#176
Merged
Conversation
The startup log and /stats endpoint always reported Database.Path, which is the sqlite default even when PROXY_DATABASE_DRIVER=postgres is set and a postgres URL is in use. Add DatabaseConfig.String() that returns the sqlite path or the postgres URL with the password redacted, and use it in both places. Fixes #173
Contributor
|
plz merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startup log and
/statsendpoint always reportedDatabase.Path, which defaults to./cache/proxy.dbeven whenPROXY_DATABASE_DRIVER=postgresandPROXY_DATABASE_URLare set and postgres is actually in use.This adds
DatabaseConfig.String()which returns the sqlite path for the sqlite driver, or the postgres connection URL with the password redacted (falling back to justpostgresif the URL isn't inpostgres://form, to avoid leaking key=value DSN credentials). Both the startup log and/statsnow use it.The
/statsJSON field is still nameddatabase_pathto avoid breaking existing consumers.Fixes #173