Use dependents library for discovery - #8
Open
andrew wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors internal/discover to delegate repository deduplication, filtering, ranking, checkout, and source/test analysis to github.com/git-pkgs/dependents, keeping only downstream-specific ecosyste.ms querying and config reconciliation logic local.
Changes:
- Replaced in-package ranking/filtering/analysis logic with
dependents.Build,dependents.Filter,dependents.Rank, anddependents.Analyze. - Extended ecosyste.ms repo metadata ingestion to include
mirror_urlto support mirror filtering. - Updated tests and module dependencies to reflect the new
dependents-based pipeline.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/discover/ecosystems.go | Adds MirrorURL to repo metadata parsed from ecosyste.ms. |
| internal/discover/discover.go | Rebuilds phase-one discovery around dependents grouping, filtering, and ranking. |
| internal/discover/discover_test.go | Updates ranking-related test to use the new ranking helper. |
| internal/discover/analyze.go | Replaces local clone/scan logic with dependents.Analyze and re-ranking. |
| internal/discover/analyze_test.go | Reworks analysis tests to use injected dependents.Checkout and new behaviors. |
| go.mod | Adds github.com/git-pkgs/dependents and related indirect dependencies. |
| go.sum | Updates sums for new direct/indirect dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+74
to
+78
| func rankCandidates(candidates []Candidate, limit int) []Candidate { | ||
| shared := make([]dependents.Candidate, len(candidates)) | ||
| byRepository := make(map[string]Candidate, len(candidates)) | ||
| for i, candidate := range candidates { | ||
| shared[i] = candidate.shared() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
git-pkgs/dependentsfor repository deduplication, health filtering, ranking, checkout, and source and test analysis. Keeps downstream's package-specific ecosyste.ms request anddownstream.tomlreconciliation local.Closes #7