Merged
Conversation
Collaborator
|
Thank you for the contribution, this is most welcome: The SVG part has been neglected for quite some time. Before I can accept the change, the errors from clippy needs to be fixed. Note that one of them puts a cap on the number of lines in a function so you may have to do a little refactoring. |
Contributor
Author
|
Thank you for your feedback @peso. All checks now pass. I'm still new to rust, so please let me know if I made some horrible blunder. |
Collaborator
|
We all have to start somewhere, but this is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
First of all, thank you so much for this project. I've been looking for just that for quite a while now.
I enhanced the SVG graph with some more details, making it look a bit like Gitlab graphs :