Skip to content

refactor(core)!: drop SortableJS dependency#2634

Draft
ghiscoding wants to merge 22 commits into
masterfrom
refactor/drop-sortablejs
Draft

refactor(core)!: drop SortableJS dependency#2634
ghiscoding wants to merge 22 commits into
masterfrom
refactor/drop-sortablejs

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jun 30, 2026

Copy link
Copy Markdown
Owner

vibe coded with mostly copilot Claude Sonnet 4.6

I first tried to migrate from SortableJS to @formkit/drag-and-drop in another branch refactor/formkit-dnd but copilot suggested to actually drop the use of any external dependency and just use native code by adding about ~350 loc now ~440 loc after all fixes. Note that this wouldn't get merged until the next major version (next year) since that could impact some E2E tests (I had to add a custom Cypress drag command to make my E2E tests pass) and some small UI differences too (e.g. no more drag animation)

Comparing the build size of my Salesforce standalone script zip file, dropping SortableJS drops the file size by about 10Kb ~9Kb (as a comparison, when I tried to migrate to @formkit/drag-and-drop, that only dropped by about ~2.5Kb, and there's still some touch issues with that approach/branch, so dropping SortableJS entirely and going native has a much larger impact for the decrease in size).

@ghiscoding ghiscoding marked this pull request as draft June 30, 2026 22:38
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (45d8afe) to head (2ce018f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2634    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files         200      201     +1     
  Lines       25317    25730   +413     
  Branches     8951     9049    +98     
========================================
+ Hits        25317    25730   +413     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding

ghiscoding commented Jun 30, 2026

Copy link
Copy Markdown
Owner Author

converting to Draft since I mainly want to see if all tests are passing, if confirmed then I'll probably close the branch and just resurrect it in our next major version in 2027-Q1. I mainly wanted to use my leftover copilot tokens before the next month rolls in

cc @zewa666

EDIT

After trying it on my linux laptop, I had to patch a few things for Firefox Linux, and also told the AI to patch for any Safari issues as well. Now it's still shaving 10Kb from my zip file but it's now increased from 100 loc to 350 loc (as per codecov), probably still worth it but quite different compared to the original AI assumption 🤔

EDIT 2

hmm I found some more issues with touch not working, and some issues with Firefox Linux, it works fine with touch with SortableJS though....

EDIT 3

hmm ok I think I managed to fix all issues, in the end it's decreasing my zip by ~9Kb now, which is probably still worth it, considering that it's a lighter approach (SortableJS was created when ES6/HTML5 just came out), but I would certainly hold on this until our next major release. It could be good to get feedback on the matter. Only thing I couldn't try is Safari/MacOS but I did ask the AI to cover it too and it's also missing animation when dragging but that is barely noticeable

Cheers

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2634

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2634

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2634

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2634

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2634

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2634

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2634

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2634

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2634

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2634

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2634

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2634

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2634

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2634

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2634

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2634

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2634

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2634

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2634

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2634

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2634

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2634

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2634

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2634

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2634

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2634

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2634

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2634

commit: 2ce018f

@ghiscoding ghiscoding changed the title refactor!: drop SortableJS dependency refactor(core)!: drop SortableJS dependency Jul 7, 2026
@ghiscoding ghiscoding added ⚠️ major version not supported until next major version breaking change labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change ⚠️ major version not supported until next major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant