refactor(core)!: drop SortableJS dependency#2634
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 200 201 +1
Lines 25317 25730 +413
Branches 8951 9049 +98
========================================
+ Hits 25317 25730 +413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
converting to Draft since I mainly want to see if all tests are passing, if confirmed then I'll probably close the branch and just resurrect it in our next major version in 2027-Q1. I mainly wanted to use my leftover copilot tokens before the next month rolls in cc @zewa666 EDIT After trying it on my linux laptop, I had to patch a few things for Firefox Linux, and also told the AI to patch for any Safari issues as well. Now it's still shaving 10Kb from my zip file but it's now increased from 100 loc to 350 loc (as per codecov), probably still worth it but quite different compared to the original AI assumption 🤔 EDIT 2 hmm I found some more issues with touch not working, and some issues with Firefox Linux, it works fine with touch with SortableJS though.... EDIT 3 hmm ok I think I managed to fix all issues, in the end it's decreasing my zip by ~9Kb now, which is probably still worth it, considering that it's a lighter approach (SortableJS was created when ES6/HTML5 just came out), but I would certainly hold on this until our next major release. It could be good to get feedback on the matter. Only thing I couldn't try is Safari/MacOS but I did ask the AI to cover it too and it's also missing animation when dragging but that is barely noticeable Cheers |
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/sql
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
@slickgrid-universal/web-mcp
commit: |
vibe coded with mostly copilot Claude Sonnet 4.6
I first tried to migrate from SortableJS to
@formkit/drag-and-dropin another branchrefactor/formkit-dndbut copilot suggested to actually drop the use of any external dependency and just use native code by adding about~350 locnow ~440 loc after all fixes. Note that this wouldn't get merged until the next major version (next year) since that could impact some E2E tests (I had to add a custom Cypress drag command to make my E2E tests pass) and some small UI differences too (e.g. no more drag animation)Comparing the build size of my Salesforce standalone script zip file, dropping SortableJS drops the file size by about
10Kb~9Kb (as a comparison, when I tried to migrate to@formkit/drag-and-drop, that only dropped by about ~2.5Kb, and there's still some touch issues with that approach/branch, so dropping SortableJS entirely and going native has a much larger impact for the decrease in size).