Skip to content

fix(regression): resolve getHeaderColumn with hidden leading columns#2585

Open
ghiscoding wants to merge 5 commits into
masterfrom
bugfix/get-header-hidden-column
Open

fix(regression): resolve getHeaderColumn with hidden leading columns#2585
ghiscoding wants to merge 5 commits into
masterfrom
bugfix/get-header-hidden-column

Conversation

@ghiscoding
Copy link
Copy Markdown
Owner

@ghiscoding ghiscoding commented May 12, 2026

fixes #2584

vibe coded a fix with copilot using GPT-5.3-Codex

TODOs

  • modify 1 example to pre-init a grid with a column that has hidden: true in at least 1 example in the column definitions and modify Cypress test accordingly
  • found another bug when hidding the first column and grouping by the second column, the group doesn't show even though it should
  • also need to verify Export Excel/PDF
Screencast_20260513_012129.webm

@ghiscoding ghiscoding changed the title fix(common): resolve getHeaderColumn with hidden leading columns fix(regression): resolve getHeaderColumn with hidden leading columns May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (e6f9826) to head (eea71df).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2585   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         197      197           
  Lines       25348    25355    +7     
  Branches     8957     8961    +4     
=======================================
+ Hits        25348    25355    +7     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2585

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2585

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2585

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2585

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2585

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2585

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2585

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2585

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2585

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2585

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2585

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2585

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2585

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2585

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2585

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2585

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2585

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2585

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2585

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2585

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2585

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2585

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2585

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2585

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2585

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2585

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2585

commit: eea71df

@ghiscoding ghiscoding force-pushed the bugfix/get-header-hidden-column branch from 3c7e688 to c29f913 Compare May 12, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setDroppedGroups crashes when a hidden column precedes the grouped column (getHeaderColumn returns undefined)

1 participant