Skip to content

ref(workerchild): add metric tracking pending futures#671

Merged
bmckerry merged 2 commits into
mainfrom
task-producer-metrics
Jun 4, 2026
Merged

ref(workerchild): add metric tracking pending futures#671
bmckerry merged 2 commits into
mainfrom
task-producer-metrics

Conversation

@bmckerry
Copy link
Copy Markdown
Member

@bmckerry bmckerry commented Jun 3, 2026

Adds a metric to get a picture of how many activations with pending futures a processing pool has.

@bmckerry bmckerry requested a review from a team as a code owner June 3, 2026 18:34
@evanh
Copy link
Copy Markdown
Member

evanh commented Jun 3, 2026

I was going to make this a gauge

You could log both? One would tell you the total/p99, and the other would tell you how many produce futures a single workerchild has to deal with.

@bmckerry bmckerry force-pushed the task-producer-metrics branch from 484f749 to 1965973 Compare June 3, 2026 18:42
Comment thread clients/python/src/taskbroker_client/worker/workerchild.py
Comment thread clients/python/src/taskbroker_client/worker/workerchild.py Outdated
Copy link
Copy Markdown
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but one question

Comment thread clients/python/src/taskbroker_client/worker/workerchild.py Outdated
@bmckerry bmckerry force-pushed the task-producer-metrics branch 2 times, most recently from 51c752d to 18906bd Compare June 4, 2026 17:18
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 18906bd. Configure here.

Comment thread clients/python/src/taskbroker_client/worker/workerchild.py Outdated
Comment thread clients/python/src/taskbroker_client/worker/workerchild.py Outdated
@bmckerry bmckerry changed the title ref(workerchild): add distribution metric for pending futures ref(workerchild): add metric tracking pending futures Jun 4, 2026
@bmckerry bmckerry force-pushed the task-producer-metrics branch from 18906bd to f26aa85 Compare June 4, 2026 19:37
@bmckerry bmckerry merged commit d07f438 into main Jun 4, 2026
27 checks passed
@bmckerry bmckerry deleted the task-producer-metrics branch June 4, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants