feat(operator): static membership#346
Open
bmcquilkin-sentry wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cfec667. Configure here.
| ) | ||
| def test_build_kafka_consumer_config( | ||
| source_config: StepConfig, | ||
| source_config: KafkaConsumerConfig, |
There was a problem hiding this comment.
Tests ignore static membership env
Low Severity
test_build_kafka_consumer_config asserts exact override_params but never clears STREAMS_KAFKA_GROUP_INSTANCE_ID. After this change, build_kafka_consumer_config injects group.instance.id from that env var, so these cases fail whenever it is set. The newer static-membership tests already use monkeypatch.delenv, so this looks like a missed update.
Reviewed by Cursor Bugbot for commit cfec667. Configure here.
evanh
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds static membership to consumers (and also adds some type fix mypy was complaining about).