fix(monitors): Prevent crash when cron detector queryObj is null - #123085
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(monitors): Prevent crash when cron detector queryObj is null#123085sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of null (reading 'slug')occurring inCronDetectorDetailswhendataSource.queryObjisnull.The root cause was that the frontend code assumed
dataSource.queryObjwould always be present, but the API can return a validCronDetectorwhere this property isnull(e.g., for misconfigured or partially-created monitors).The solution implements the following changes:
CronDetectorDetails(static/app/views/detectors/components/details/cron/index.tsx):return nullguard whendataSource.queryObjisnull, ensuring that subsequent code relying onqueryObjis not executed.useStateanduseCallbackhooks to before the early return to comply with React's Rules of Hooks.useDocsPanelanduseMonitorProcessingErrorsto use optional chaining (?.) fordataSource.queryObj.slug.getLatestCronMonitorEnvto safely handle anullqueryObj.useMonitorProcessingErrors(static/app/views/insights/crons/useMonitorProcessingErrors.tsx):monitorSlugtype tostring | undefined.enabled: !!monitorSlugoption touseApiQueryto prevent API calls whenmonitorSlugisundefined.deleteMonitorProcessingErrorByTypeprovide a fallback empty string (monitorSlug ?? '') whenmonitorSlugisundefined.useDocsPanel(static/app/views/detectors/components/details/cron/index.tsx):monitorSlugparameter type tostring | undefined.monitorSlug ?? ''toMonitorQuickStartGuideto satisfy itsmonitorSlug: stringprop type.Fixes JAVASCRIPT-3BHN
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.