perf(crons): Prefetch active incident in clock tasks consumer - #123084
Open
wedamija wants to merge 1 commit into
Open
perf(crons): Prefetch active incident in clock tasks consumer#123084wedamija wants to merge 1 commit into
wedamija wants to merge 1 commit into
Conversation
Removing one more query from #123067. Also relies on this branch
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00f9ed7. Configure here.
| # Only a hit short-circuits: an incident can be opened part way through | ||
| # a batch, so a miss has to re-query. | ||
| if self._prefetched_active_incident is not None: | ||
| return self._prefetched_active_incident |
Contributor
There was a problem hiding this comment.
Stale incident cache reopens resolved issues
Medium Severity
A cached hit on active_incident is never invalidated. If a successful check-in resolves that incident while the batch is still running, later clock tasks still receive the prefetched MonitorIncident and dispatch occurrences that can reopen the already-resolved issue.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 00f9ed7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing one more query from #123067. Also relies on this branch