fix(issue detectors): Ignore parentless spans in N+1 API calls detector - #123062
Draft
lobsterkatie wants to merge 2 commits into
Draft
fix(issue detectors): Ignore parentless spans in N+1 API calls detector#123062lobsterkatie wants to merge 2 commits into
lobsterkatie wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in our N+1 API calls detector, wherein the fact that it's not rejecting parentless spans is causing our "are these two spans similar enough to count as part of a N+1?" check to crash, because it expects a parent span id on both spans.
This fixes that by adding a check for parent span id to the detector's
_is_span_eligiblemethod, and declaring as ineligible any span missing one. Because that would have added an extra required line to all of the many test cases for that function, I instead refactored the good span and bad span tests so that the span boilerplate is part of the test function, with only the single good or bad value as the test case. There were also a number of ineligibility reasons which weren't tested, so I added tests cases for those as well.Fixes https://sentry.sentry.io/issues/7694491240