fix(perf-detection): skip spans with PII-redacted http.response_content_length#119480
Closed
billyvg wants to merge 1 commit into
Closed
fix(perf-detection): skip spans with PII-redacted http.response_content_length#119480billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
…nt_length When PII scrubbing replaces encoded_body_size with '[Filtered]' or '[REDACTED]', int() raises ValueError and causes 'Failed to detect performance problems' errors. Gracefully skip those spans instead. Fixes SENTRY-5R9R
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SENTRY-5R9R (
ValueError: invalid literal for int() with base 10: '[Filtered]')In
LargeHTTPPayloadDetector.visit_span, the code convertshttp.response_content_lengthfromstrtointwhen the value arrives as a string. When PII scrubbing is active, that value can be replaced with a non-numeric sentinel like'[Filtered]'or'[REDACTED]', causingint()to raiseValueError. This bubbles up as"Failed to detect performance problems"logged from the spans process-segments consumer.Root cause:
large_http_payload_detector.py:59— unconditionalint(encoded_body_size)when the value is a scrubbed string.Fix: Wrap the conversion in
try/except ValueErrorandreturnearly (skip the span) when the value is non-numeric. The span can't be evaluated anyway.Evidence from Sentry:
spans.consumers.process_segments.process_segmentencoded_body_size: "'[REDACTED]'"process-segmentsconsumer podsChanges
src/sentry/issue_detection/detectors/large_http_payload_detector.py: wrapint()cast intry/except ValueError, returning early for non-parseable valuestests/sentry/issue_detection/test_large_http_payload_detector.py: addtest_does_not_raise_on_redacted_payload_sizecovering'[Filtered]','[REDACTED]', and'***'Claude Session
https://claude.ai/code/session_01AQUEoDMYw8jPUTwTHHHLt6
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code