fix(perf): skip spans with non-numeric encoded_body_size in LargeHTTPPayloadDetector#119474
Closed
billyvg wants to merge 1 commit into
Closed
fix(perf): skip spans with non-numeric encoded_body_size in LargeHTTPPayloadDetector#119474billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
…PayloadDetector When `http.response_content_length` is a string like '[NaN]' (from scrubbed or filtered span data), `int()` raises ValueError causing detection to fail loudly. Wrap the conversion in try/except to skip such spans gracefully. Fixes SENTRY-5R9R
Member
Author
|
added encoded_body_size as safe field instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SENTRY-5R9R —
ValueError: invalid literal for int() with base 10: '[NaN]'inLargeHTTPPayloadDetector.Root cause: In
large_http_payload_detector.py:59,http.response_content_lengthspan data can arrive as the string'[NaN]'(from scrubbed or filtered browser payloads). The bareint(encoded_body_size)call raisesValueError, which propagates throughdetect_performance_problems → _run_legacy_detectors → run_detector_on_dataand gets caught by thelogging.exception("Failed to detect performance problems")path — generating a Sentry error on every affected span.Evidence from Sentry issue:
encoded_body_size = "'[NaN]'"visible in local variablessentry/issue_detection/detectors/large_http_payload_detector.py, line 59Fix: Wrap the
int()conversion in atry/except ValueErrorand return early, skipping spans with unparseable body sizes.A test
test_skips_span_with_nan_encoded_body_sizeis added to confirm the behavior.Claude session: https://claude.ai/code/session_015pwRdeFeVj3ZSak5yEbtaY
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code