test(billing): mirror the AM3 replay checkout payload in fixtures (REVENG-264)#119027
Draft
dashed wants to merge 1 commit into
Draft
test(billing): mirror the AM3 replay checkout payload in fixtures (REVENG-264)#119027dashed wants to merge 1 commit into
dashed wants to merge 1 commit into
Conversation
…VENG-264) The backend now includes 5,000 replays on AM3 plans and starts checkout reserved tiers at the plan default: the billing-config payload defaults replays to 5,000, prices the 5,000 tier at $0 (PAYG for 5,000-10,000 moves to $0.0045), and no longer offers the grandfathered 50 tier, which stays valid only for existing subscriptions. Update the billing-config and AM3 plan fixtures to match, and adjust the checkout expectations to what the frontend already does with that payload: the slider's lowest tick becomes 5,000 and a carried-forward 50 snaps up to it, so checkout pre-selects 5,000 with no frontend code change. The volume sliders also stop auto-showing for a sponsored plan's carried 500 replays because the snapped tier is now included at $0, so that test expands them explicitly. Subscription planDetails fixtures keep the full tier list, matching the backend, so stored grandfathered volumes still render.
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns the frontend test fixtures with the AM3 replay repackaging shipped in getsentry/getsentry#20920: AM3 plans include 5,000 replays, and the checkout billing-config payload starts each category's reserved tiers at the plan default, so the grandfathered 50-replay tier is no longer offered at checkout.
No frontend source changes. The checkout already does the right thing with the new payload — this PR proves it at the test level:
BillingConfigFixturenow returnsdefaultReserved.replays: 5000and filters AM3 plan tier lists to buckets ≥ 5,000 (AM3_CHECKOUT_PLANS), mirroring the backend'sstart_at_defaultcheckout serialization. SubscriptionplanDetailsfixtures keep the full tier list, matching the backend, so stored grandfathered volumes still render.am3Plansfixture pricing matches the new config: the 5,000 replay tier is $0 (renders as Included), and the 5,000–10,000 PAYG band moves to $0.0045. Values were generated from the backend plan config, not hand-derived.Behavior the updated specs pin
5,000 replays / mofromdefaultReserved.Testing
34 affected suites pass (345 tests): all
amCheckoutspecs, subscription-page specs, and every other consumer of the touched fixtures. Typecheck and lint clean.Ship order
Fixtures describe the payload of getsentry/getsentry#20920 — land this together with or after that PR.
REVENG-264