Skip to content

feat(issues): Use shared markdown component for activity notes#116300

Merged
scttcper merged 2 commits into
masterfrom
scttcper/note-markdown-renderer
May 27, 2026
Merged

feat(issues): Use shared markdown component for activity notes#116300
scttcper merged 2 commits into
masterfrom
scttcper/note-markdown-renderer

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented May 27, 2026

Activity notes and the note preview were still using MarkedText with local markdown styles layered on top. This swaps both to the core Markdown component and lets it own the rendered markdown styling.

Only real functional change is internal links (missing https://) are no longer allowed, which i think is fine.

before

image

after

image

Activity notes and the note preview were still using MarkedText with local markdown styles layered on top. Swap both to the core Markdown component and let it own the rendered markdown styling.

Also trims some dead note input styling while we are here.

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.58%

@scttcper scttcper changed the title ref(issues): Use core markdown for activity notes feat(issues): Use shared markdown component for activity notes May 27, 2026
@scttcper scttcper marked this pull request as ready for review May 27, 2026 15:04
@scttcper scttcper requested review from a team as code owners May 27, 2026 15:04
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 17b9663. Configure here.

<Text as="span" size="sm" variant="muted">
{t('Markdown supported')}
</Text>
</Flex>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flex color prop doesn't set CSS color for icon

Medium Severity

The color="content.secondary" prop on Flex doesn't translate to a CSS color property. The Container/Flex layout component doesn't support a color prop — it only handles layout-related CSS properties like padding, background, border, etc. This prop either fails to compile or gets forwarded as a no-op HTML attribute. The old MarkdownIndicator styled component correctly set color via CSS. The Text child with variant="muted" still gets the right color, but IconMarkdown loses its secondary content color.

Fix in Cursor Fix in Web

Triggered by project rule: Frontend guidelines

Reviewed by Cursor Bugbot for commit 17b9663. Configure here.

Bugbot caught that Flex does not own a color prop, so the markdown icon was not guaranteed to stay muted.

Use the icon variant API instead.
@scttcper scttcper merged commit 4142da1 into master May 27, 2026
74 checks passed
@scttcper scttcper deleted the scttcper/note-markdown-renderer branch May 27, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants