Skip to content

test(eap): Query typed-colon attribute as boolean instead of number#116299

Merged
phacops merged 1 commit into
masterfrom
fix/eap-test-typed-attributes-number-not-bool
May 27, 2026
Merged

test(eap): Query typed-colon attribute as boolean instead of number#116299
phacops merged 1 commit into
masterfrom
fix/eap-test-typed-attributes-number-not-bool

Conversation

@phacops
Copy link
Copy Markdown
Contributor

@phacops phacops commented May 27, 2026

Summary

  • test_typed_attributes_with_colons stored a boolean and queried it as a ,number], which only worked because the eap-items consumer double-wrote booleans into the float columns
  • Snuba is removing that double-write in ref(eap-items): Stop double writing booleans into float columns snuba#7689, breaking the assertion in Snuba CI
  • Query the same attribute with its real ,boolean] type so the colon-in-key check is exercised against the column the value actually lives in

Test plan

  • CI on this branch

Refs getsentry/snuba#7689

@phacops phacops requested a review from a team as a code owner May 27, 2026 14:31
@phacops phacops force-pushed the fix/eap-test-typed-attributes-number-not-bool branch from 62a785f to b74b258 Compare May 27, 2026 14:55
@phacops phacops changed the title test(eap): Use number value in typed-number colon test test(eap): Mark bool-as-number colon test as xfail May 27, 2026
Comment thread tests/snuba/api/endpoints/test_organization_events_span_indexed.py Outdated
The test stored a boolean and queried it as a number, which only worked
because the eap-items consumer double-wrote booleans into the float
columns. Snuba is removing that double-write (getsentry/snuba#7689), so
query the attribute with its real boolean type to keep the colon-in-key
check meaningful.

Refs getsentry/snuba#7689
Co-Authored-By: Claude <noreply@anthropic.com>

Agent transcript: https://claudescope.sentry.dev/share/3VSGJW-FUgGjcTG0eu4482ebu89oDWTEdNjr8EZI-O4
@phacops phacops force-pushed the fix/eap-test-typed-attributes-number-not-bool branch from b74b258 to beeb44c Compare May 27, 2026 15:16
@phacops phacops changed the title test(eap): Mark bool-as-number colon test as xfail test(eap): Query typed-colon attribute as boolean instead of number May 27, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit beeb44c. Configure here.

Comment thread tests/snuba/api/endpoints/test_organization_events_span_indexed.py
@phacops phacops enabled auto-merge (squash) May 27, 2026 15:29
@phacops phacops merged commit 005f194 into master May 27, 2026
60 checks passed
@phacops phacops deleted the fix/eap-test-typed-attributes-number-not-bool branch May 27, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants