ref(replays): Remove control-silo URL pattern for removed data export endpoint#116298
Open
DominikB2014 wants to merge 1 commit into
Open
Conversation
… endpoint The /api/0/data-export/notifications/google-cloud/ endpoint is being removed in PR #116232. Drop its entry from the hand-maintained control-silo URL pattern list. The generated knownSentryApiUrls.generated.ts entry will be cleaned up the next time tools/api_urls_to_typescript is run. Refs REPLAY-920 Refs VULN-1598 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.58% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/0/data-export/notifications/google-cloud/fromstatic/app/data/controlsiloUrlPatterns.ts.Notes
static/app/utils/api/knownSentryApiUrls.generated.tsstill lists the URL on line 33. That file is auto-generated bypython3 -m tools.api_urls_to_typescriptand its header explicitly notes that it is safe to deploy alongside backend changes — it will be cleaned up the next time the generator runs against a backend that no longer registers the route.Refs REPLAY-920
Refs VULN-1598