feat(bitbucket-server): Add API-driven pipeline backend for Bitbucket Server integration setup#116295
Draft
evanpurkhiser wants to merge 1 commit into
Conversation
Comment on lines
+323
to
+326
| if not request_token.get("oauth_token"): | ||
| lifecycle.record_failure( | ||
| "missing oauth_token", extra={"url": validated_data["url"]} | ||
| ) |
Contributor
There was a problem hiding this comment.
Missing validation of oauth_token_secret causes uncaught KeyError in OAuthApiStep
The guard at line 323 only validates oauth_token but not oauth_token_secret; if the Bitbucket Server response includes oauth_token but omits oauth_token_secret, client.get_access_token() raises a KeyError on request_token["oauth_token_secret"] that is not caught by the except ApiError block in OAuthApiStep.handle_post, resulting in an unhandled 500.
Evidence
InstallationConfigApiStep.handle_post(line 323) guards onlyrequest_token.get("oauth_token")before storing the token in pipeline state.OAuthApiStep.handle_postlater callsself._client(pipeline).get_access_token(request_token, ...)insidetry: ... except ApiError.BitbucketServerSetupClient.get_access_token(client.py line ~65) accessesrequest_token["oauth_token_secret"]as a bare dict key — no.get(), no fallback.KeyErroris not a subclass ofApiError, so it propagates past the catch block as an unhandled exception.build_integration(integration.py line 572) also accessesaccess_token["oauth_token_secret"]directly, compounding the risk if the access-token response is similarly incomplete.
Suggested fix: Extend the existing guard to also validate oauth_token_secret.
Suggested change
| if not request_token.get("oauth_token"): | |
| lifecycle.record_failure( | |
| "missing oauth_token", extra={"url": validated_data["url"]} | |
| ) | |
| if not request_token.get("oauth_token_secret"): | |
| lifecycle.record_failure( | |
| "missing oauth_token_secret", extra={"url": validated_data["url"]} | |
| ) | |
| return PipelineStepResult.error("Missing oauth_token_secret") |
Identified by Warden sentry-backend-bugs · RUP-A8A
28f532a to
2d49f16
Compare
… Server integration setup Implement `get_pipeline_api_steps()` on `BitbucketServerIntegrationProvider` with two steps: installation config (validates URL, RSA private key, and consumer key length, then fetches an OAuth 1.0a request token from the Bitbucket Server instance), and an OAuth callback step that builds the authorize URL from the request token and exchanges the callback's `oauth_token` (used by Bitbucket Server as the verifier) for an access token. Legacy `InstallationConfigView`, `OAuthLoginView`, and `OAuthCallbackView` remain in place so in-flight installs can complete via the existing flow; they will be removed in a follow-up once the API flow has been validated in production.
2d49f16 to
b88bb62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
get_pipeline_api_steps()onBitbucketServerIntegrationProviderwith two steps: installation config (validates URL, RSA private key, and consumer key length, then fetches an OAuth 1.0a request token from the Bitbucket Server instance), and an OAuth callback step that builds the authorize URL from the request token and exchanges the callback'soauth_token(used by Bitbucket Server as the verifier) for an access token.Legacy
InstallationConfigView,OAuthLoginView, andOAuthCallbackViewremain in place so in-flight installs can complete via the existing flow; they will be removed in a follow-up (VDY-103) once the API flow has been validated in production.Ref VDY-99